Conversation
aknot242
changed the title
There was a problem hiding this comment.
Pull request overview
Adds Red Hat certification checks and prepares collection metadata and documentation for release 0.9.0.
Changes:
- Adds certification, lint, and Dependabot configuration.
- Raises dependency and Ansible requirements.
- Updates playbooks to fully qualified role names.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.ansible-lint |
Configures production linting exclusions. |
.github/SECURITY.md |
Normalizes apostrophes. |
.github/dependabot.yml |
Enables weekly action updates. |
.github/workflows/certification.yml |
Adds certification checks. |
README.md |
Updates release and dependency guidance. |
galaxy.yml |
Bumps version and dependencies. |
meta/runtime.yml |
Raises the Ansible minimum. |
playbooks/deploy-nginx.yml |
Uses a fully qualified role name. |
playbooks/deploy-nginx-web-server.yml |
Qualifies included roles. |
playbooks/deploy-nginx-web-server-proxy.yml |
Qualifies included roles. |
playbooks/deploy-nginx-plus.yml |
Qualifies the NGINX role. |
playbooks/deploy-nginx-plus-app-protect.yml |
Qualifies included roles. |
playbooks/deploy-nginx-plus-app-protect-web-server-proxy.yml |
Qualifies included roles. |
playbooks/deploy-nginx-app-protect.yml |
Qualifies the App Protect role. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
+20
| | [nginxinc.nginx](https://github.com/nginxinc/ansible-role-nginx) | Install NGINX | 0.26.0 | | ||
| | [nginxinc.nginx_config](https://github.com/nginxinc/ansible-role-nginx-config) | Configure NGINX | 0.7.1 | | ||
| | [nginxinc.nginx_app_protect](https://github.com/nginxinc/ansible-role-nginx-app-protect) | Install and configure NGINX App Protect | 0.10.0 | |
| # for each affected version of ansible-core (for example, `tests/sanity/ignore-2.18.txt`) and add corresponding entries. | ||
| jobs: | ||
| call: | ||
| uses: ansible-collections/partner-certification-checker/.github/workflows/certification-reusable.yml@v4.0.0 |
alessfg
requested changes
Aug 14, 2026
| @@ -0,0 +1,50 @@ | |||
| --- | |||
| # This workflow calls a pinned version of the | |||
Collaborator
There was a problem hiding this comment.
Lets add a comment up top here saying that this got workflow was copied from the certification repo per the quickstart https://github.com/nginxinc/ansible-collection-nginx/pull/12/changes#diff-d519a9b910e45c00725de9beec3fbc97be24eaf1586c66943a17b7908b115f1cR22-R24
| # for each affected version of ansible-core (for example, `tests/sanity/ignore-2.18.txt`) and add corresponding entries. | ||
| jobs: | ||
| call: | ||
| uses: ansible-collections/partner-certification-checker/.github/workflows/certification-reusable.yml@v4.0.0 |
Collaborator
There was a problem hiding this comment.
This should use a SHA. Related conversation here ansible-collections/partner-certification-checker#65 but version tags vs SHAs are simply not great from a security perspective even if the user experience is better
alessfg
changed the title
github-project-automation
Bot
moved this to In progress
in NGINX Ansible roles & collection
github-project-automation
Bot
moved this from In progress
to Review in progress
in NGINX Ansible roles & collection
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: aknot242 <4582399+aknot242@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add Red Hat's reusable GitHub Actions to check whether an Ansible collection is ready for certification on Red Hat Ansible Automation Hub.
What it checks
The certification checker runs the same types of checks used during the Automation Hub import process, including:
Galaxy importer checks
Ansible Lint checks
Ansible sanity tests
Update the collection to the latest version in preparation for release.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADMEandCHANGELOG)