feat: standalone certificates for containers without VIRTUAL_HOST - #1294
Open
JamBalaya56562 wants to merge 1 commit into
Open
feat: standalone certificates for containers without VIRTUAL_HOST#1294JamBalaya56562 wants to merge 1 commit into
JamBalaya56562 wants to merge 1 commit into
Conversation
JamBalaya56562
force-pushed
the
feat/container-standalone-certs
branch
from
July 17, 2026 22:59
7de4d8d to
038d7e7
Compare
JamBalaya56562
force-pushed
the
feat/container-standalone-certs
branch
from
August 8, 2026 22:51
038d7e7 to
6080ed1
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JamBalaya56562
force-pushed
the
feat/container-standalone-certs
branch
from
August 22, 2026 00:24
6080ed1 to
14be7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the feature proposed in #1128 (standalone certificates from
LETSENCRYPT_HOSTalone, e.g. for an SMTP container that is not proxied), using the approach suggested there: the template now detects containers withoutVIRTUAL_HOST/VIRTUAL_HOST_MULTIPORTSinstead of routing every certificate throughadd_standalone_configuration, so proxied certificates keep the exact same code path and two-container setups without a shared/etc/nginx/conf.dare unaffected.letsencrypt_service_data.tmplrenders a newACME_STANDALONE_CONTAINERSarray listing the identifiers (SAN and single-domain forms) of containers that have anACME_HOST/LETSENCRYPT_HOSTbut noVIRTUAL_HOST/VIRTUAL_HOST_MULTIPORTS.update_certsruns those identifiers through the existing standalone challenge configuration pre-pass (shared withletsencrypt_user_datacertificates); the post-issuance conf removal and cleanup paths are unchanged.LETSENCRYPT_RESTART_CONTAINERworks for these certificates, which theletsencrypt_user_dataroute couldn't offer.standalone_containerintegration test: aLETSENCRYPT_HOST-only container gets its certificate through the standalone flow, and a proxied container is never classified as standalone.docs/Standalone-certificates.md.Verified locally by rendering the template with docker-gen against dummy containers (SAN, single-domain,
VIRTUAL_HOSTandVIRTUAL_HOST_MULTIPORTSvariants): only the containers without a virtual host are listed inACME_STANDALONE_CONTAINERS.Supersedes #1128 if accepted — credit to @pini-gh for the original proposal.
🤖 Generated with Claude Code