Do not offer create and delete widgets to teachers if they do not have the rights to use them, resolves #14 and #15 - #16
Open
abias wants to merge 3 commits into
Open
Do not offer create and delete widgets to teachers if they do not have the rights to use them, resolves #14 and #15#16abias wants to merge 3 commits into
abias wants to merge 3 commits into
Conversation
…l/archiving:create capability could see the widgets to create archives unnecessarily, resolves ngandrass#14
…l/archiving:delete capability could see the widgets to delete archives unnecessarily, resolves ngandrass#15
…n the archive detail page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the raised issues and was manually tested.
Please note that there aren't any automated tests for these fixes included as they are not straightforward to be tested with PHPUnit (which exist already in the plugin) and as there isn't a Behat test baseline yet (which I could have extended to cover these cases)