fix(web-app): truncate long plugin names in the admin sidebar nav - #483
Open
newmanw wants to merge 1 commit into
Open
fix(web-app): truncate long plugin names in the admin sidebar nav#483newmanw wants to merge 1 commit into
newmanw wants to merge 1 commit into
Conversation
Plugin titles in the admin sidebar nav could wrap onto a second line, but .nav-item has a fixed 36px height and no overflow handling, so the wrapped line spilled out and overlapped the nav item below it. Truncate the plugin label with an ellipsis instead, scoped to a dedicated .nav-label--truncate class so the Users/ Devices nav-labels (which carry a matBadge) are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nav-itemhas a fixed36pxheight and no overflow handling, so the wrapped line spilled out and visually overlapped the nav item below it..nav-label--truncatemodifier class rather than the shared.nav-labelclass —.nav-labelis also used by the Users/Devices nav items which carry amatBadge, andoverflow: hiddenthere would risk clipping the badge indicator.Test plan