fix(service): await attachment reads during CSV export - #481
Open
newmanw wants to merge 1 commit into
Open
Conversation
Attachments were read with observation.attachments.forEach(async ...), but forEach doesn't await its callback, so the CSV row/archive entry was returned before attachment content had actually been read and appended, causing attachments to be dropped or missing from CSV exports. Use a for...of loop so each attachment is awaited in order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
observation.attachments.forEach(async attachment => {...})doesn't await its async callback, soexportColumncould return before attachment content had actually been read and appended to the export archive — attachments could be missing or incomplete in CSV exports depending on timing.forEachwith afor...ofloop so each attachment'sreadContent/archive.appendis properly awaited in order before the column is returned.Test plan