feat: Add linting of FASTQ with FQ/LINT - #1763
Open
adamrtalbot wants to merge 4 commits into
Open
Conversation
Checks FASTQ files early in pipeline to catch linting errors. Simplest possible implementation, which just runs FQ/LINT right now.
adamrtalbot
requested review from
FriederikeHanssen and
maxulysse
as code owners
December 17, 2024 17:23
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
Member
|
I'm sure some tests will fails given this new input, but looking nice, thanks for the PR |
maxulysse
previously approved these changes
Dec 17, 2024
maxulysse
left a comment
Member
There was a problem hiding this comment.
We might want to skip all qc tools in our regular tests, and just do one with all the qc tools.
Stellar work as usual @adamrtalbot
Contributor
Author
|
@maxulysse halp: |
Member
|
I'll try to have a look, but I can't promise anything today |
maxulysse
reviewed
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks FASTQ files early in pipeline to catch linting errors.
Simplest possible implementation, which just runs FQ/LINT right now.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).