Skip to content

feat: Add linting of FASTQ with FQ/LINT - #1763

Open
adamrtalbot wants to merge 4 commits into
nf-core:devfrom
adamrtalbot:add_fq_lint_to_pipeline
Open

feat: Add linting of FASTQ with FQ/LINT#1763
adamrtalbot wants to merge 4 commits into
nf-core:devfrom
adamrtalbot:add_fq_lint_to_pipeline

Conversation

@adamrtalbot

Copy link
Copy Markdown
Contributor

Checks FASTQ files early in pipeline to catch linting errors.

Simplest possible implementation, which just runs FQ/LINT right now.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Checks FASTQ files early in pipeline to catch linting errors.

Simplest possible implementation, which just runs FQ/LINT right now.
@nf-core-bot

Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@maxulysse

Copy link
Copy Markdown
Member

I'm sure some tests will fails given this new input, but looking nice, thanks for the PR

maxulysse
maxulysse previously approved these changes Dec 17, 2024

@maxulysse maxulysse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to skip all qc tools in our regular tests, and just do one with all the qc tools.

Stellar work as usual @adamrtalbot

@adamrtalbot

Copy link
Copy Markdown
Contributor Author

@maxulysse halp:

ERROR ~ Cannot invoke method split() on null object

@maxulysse

Copy link
Copy Markdown
Member

I'll try to have a look, but I can't promise anything today

Comment thread workflows/sarek/main.nf Outdated
@maxulysse maxulysse added this to the 3.7 milestone Oct 7, 2025
@famosab famosab modified the milestones: 3.7, 3.9.0 Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants