fix(web): cover composer with move dialog - #6854
Conversation
|
🧪 This PR has changes that need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready (and design/product have signed off, where applicable). |
mrcfps
left a comment
There was a problem hiding this comment.
@Siri-Ray thank you for the clean, well-aimed fix — this is a nice piece of stacking-context surgery.
I reviewed both changed files against the live diff at 390103c04f326e9beef4c6ff86e42f49b8bbf5b6. Portaling MoveToTeamConfirmDialog to document.body and dropping modal-backdrop--no-blur is the right pair of changes: the composer already lives in a body-level .chat-composer-fixed-layer (z-index: 45), while the dialog was trapped inside the workspace stacking context and also opted out of the shared backdrop blur. After this change it matches the established SignOutConfirmDialog / WhatsNewPopup pattern, and the shared .modal-backdrop (z-index: 1700) can dim and blur the composer the same way it treats the rest of the editor.
The home recent-projects confirmations keep their own inline Dialogs with --no-blur, so this stays scoped to the editor/workspace hosts (FileWorkspace and FileViewer). The new Vitest spec is a real red-spec: it asserts the alertdialog escapes the workspace host, lands on document.body, and no longer carries the no-blur class.
No correctness, safety, or maintainability issues in the changed ranges. Appreciate the focused regression test and the screenshot — this should feel much more consistent when moving a project from the editor. 🙌
🔁 Powered by Looper · runner=reviewer · agent=grok-build · An autonomous AI dev team for your GitHub repos.
|
Thanks for the contribution. I completed QA validation for this PR at QA Acceptance Record Scope:
Verified:
Conclusion:
|
Why
The editor's “Move to team space” confirmation left the lower-left prompt composer bright and visually interactive while the rest of the editor was blurred. The composer is rendered in a body-level fixed portal, but the dialog was trapped inside the workspace stacking context and also opted out of the shared backdrop blur.
This fixes the editor modal hierarchy so the composer participates in the same background treatment as the canvas and surrounding chrome.
What users will see
Opening the move-to-team confirmation from the editor now blurs and dims the entire editor, including the lower-left prompt composer. The confirmation dialog remains sharp and highlighted above the backdrop.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-packflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope. Include a paragraph on what we get vs. what bytes we ship (seeCONTRIBUTING.md→ Code style)Screenshots
After — the whole editor and composer share the blurred backdrop while the confirmation stays sharp:
Bug fix verification
apps/web/tests/components/MoveToTeamConfirmDialog.test.tsxmain(the dialog remained inside the workspace stacking context) and green on this branch.Validation
corepack pnpm guardcorepack pnpm typecheckcorepack pnpm --filter @open-design/web typecheckcorepack pnpm --filter @open-design/web exec vitest run -c vitest.config.ts tests/components/MoveToTeamConfirmDialog.test.tsx@open-design/websuite: 6,476 passed; one unrelated concurrentSettingsDialog.execution.test.tsxretry-count assertion failed, then passed in an isolated rerunNo GitHub issue is linked; this was directly reported and reproduced in the editor.