fix stale P1 and P2 E2E coverage - #6820
Conversation
|
🧪 This PR has changes that need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready. |
nettee
left a comment
There was a problem hiding this comment.
The updated E2E setup and deck hit-testing fix align with the current product behavior. I found one non-blocking test-hardening issue in the reload regression; the concrete detail is inline. I verified pnpm guard, the workspace typechecks, the E2E typecheck, Playwright discovery, and the targeted reload/deck regressions.
| runId, | ||
| runStatus: 'failed', | ||
| runStatus: 'succeeded', | ||
| hasContent: true, |
There was a problem hiding this comment.
The poll result is no longer retained or re-asserted before the next action. expect.poll can observe producedFiles: [], then the asynchronous result-delivery path can populate that field before unrouteAll/reload, allowing the post-reload assertion to pass without proving that reload performed the reconciliation. The previous version's preconditionRef explicitly protected this boundary. Please retain the matching poll snapshot (or re-read and assert producedFiles: [] immediately before unroute/reload) so this regression remains tied to the dropped-transport state at the point of reload.
Why
The prerelease P1/P2 run exposed a group of failures caused by tests that still targeted retired entry points, outdated request contracts, and superseded state-reconciliation behavior. Keeping those assertions produced false regression signals. The same run also uncovered a real deck navigation bug: the controls were visible, but the preview iframe intercepted pointer events and prevented clicks.
What users will see
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-packflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope. Include a paragraph on what we get vs. what bytes we ship (seeCONTRIBUTING.md→ Code style)Screenshots
No visual styling changes. This fixes pointer hit testing for the existing floating deck navigation.
Bug fix verification
e2e/ui/app.test.ts(deck-pagination-per-file-isolated)mainand green on this branch? Yes. Onmain, it consistently timed out withiframe intercepts pointer events; it passes on this branch.Validation
pnpm guardpnpm typecheckpnpm --filter @open-design/e2e typecheckpnpm --filter @open-design/web typecheckgit diff --check