Add Design System: Spendline plugin - #6794
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca3ae36b97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "name": "design-system-spendline-msqb1t49", | ||
| "title": "Design System: Spendline", | ||
| "version": "0.1.0", | ||
| "description": "--- name: Spendline description: A calm, decision-first FinOps workspace that keeps expenditure posture, evidence, and action in one operational system. colors: fog-canvas: \"#f6f7f9\" white-plane: \"#ffffff\" blue-wash: \"#e", |
There was a problem hiding this comment.
Replace the truncated marketplace description
The manifest description contains a truncated serialization of the YAML frontmatter rather than the intended sentence. Installed-plugin cards, search, details, and chat context consume this field directly, so users will see text beginning with --- name: Spendline ... and ending mid-color value. Replace it with the complete human-readable description from SKILL.md.
AGENTS.md reference: plugins/AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
| @@ -0,0 +1,326 @@ | |||
| --- | |||
| name: Spendline | |||
There was a problem hiding this comment.
Align the portable skill name with the plugin ID
For direct Agent Skills consumption or od plugin export, this SKILL.md is the portable contract, but its name is uppercase and differs from both the folder and manifest ID (design-system-spendline-msqb1t49). The repository plugin spec requires these identifiers to match and use lowercase letters, numbers, and hyphens; consumers enforcing that contract can reject or misidentify the exported skill. Keep “Spendline” as the display title, but set this field to the stable plugin ID.
Useful? React with 👍 / 👎.
|
Thanks @ihoti2001 — shipping the full plugin package with source and provenance files is the right shape for a design-system submission. Before the reviewer queue picks this up, could you expand the PR body with the missing Why / What users will see / Surface area / Validation sections? That makes it much easier to scope the addition. 💡 To drive this PR to merge hands-free, paste this to your AI coding agent (Claude Code / Codex / opencode / Cursor …): |
nettee
left a comment
There was a problem hiding this comment.
I found two merge-safe metadata fixes in the new Spendline plugin: the sidecar description is truncated, and the portable skill name does not match the stable plugin identity. The design-system content and runtime checks otherwise look sound; the repository guard, full typecheck, plugin-runtime typecheck/tests, and local plugin validation all pass.
Fallback location — new Spendline plugin SKILL.md frontmatter, line 2: the portable Agent Skills frontmatter uses name: Spendline, while the folder and sidecar identity use a separate lowercase slug. The daemon skill registry uses this frontmatter name as the skill id, and consumers that enforce slug-safe Agent Skills names can reject or misidentify the exported skill. Keep Spendline as the display title in open-design.json, but set this field to the sidecar's stable lowercase plugin id so direct skill consumption and plugin export resolve the same identity.
| "name": "design-system-spendline-msqb1t49", | ||
| "title": "Design System: Spendline", | ||
| "version": "0.1.0", | ||
| "description": "--- name: Spendline description: A calm, decision-first FinOps workspace that keeps expenditure posture, evidence, and action in one operational system. colors: fog-canvas: \"#f6f7f9\" white-plane: \"#ffffff\" blue-wash: \"#e", |
There was a problem hiding this comment.
The manifest description is a truncated serialization of the skill frontmatter rather than the complete human-readable summary. Plugin cards, search/details views, and chat context use this field, so users will see an incomplete description even though the source skill has the full sentence. Replace this value with the complete Spendline description (or generate it from the parsed frontmatter) and add a manifest-validation fixture that rejects truncated descriptions.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.|
Hey @ihoti2001 — @nettee has the current actionable items covered on this head. The two fixes to make next are:
Once those are addressed, the next pass can focus on the updated head. |
Add Design System: Spendline (design-system-spendline-msqb1t49) plugin.
Version: 0.1.0
Description: --- name: Spendline description: A calm, decision-first FinOps workspace that keeps expenditure posture, evidence, and action in one operational system. colors: fog-canvas: "#f6f7f9" white-plane: "#ffffff" blue-wash: "#e