Add cognitive-law audit mode to ui-ux-pro-max skill - #300
Conversation
mrgoonie
left a comment
There was a problem hiding this comment.
Summary: The cognitive-law audit checklist is a useful UX-review addition, but this PR edits only the installed Claude skill copy instead of the repo's canonical source template. As submitted, the change can be lost on regeneration and will not propagate to packaged CLI assets or other platform templates.nnRisk level: MediumnnMandatory gates:n- Duplicate/prior implementation: clear — no existing cognitive-law/human-centered audit section or overlapping issue/PR found.n- Project standards: issue found — CLAUDE.md defines src/ui-ux-pro-max/ as the source of truth, with templates edited under src/ui-ux-pro-max/templates/ and then synced to cli/assets.n- Strategic necessity: clear value — a structured UX audit mode fits the skill's review/quality-gate purpose.n- CI/checks: missing/not required for the metadata-only change.nnFindings:n- Important: The PR changes only .claude/skills/ui-ux-pro-max/SKILL.md, while CLAUDE.md says src/ui-ux-pro-max/ is the source of truth and template changes belong in src/ui-ux-pro-max/templates/. Please move this audit-mode content into the canonical template, then regenerate/sync the derived .claude skill and cli/assets template copies as appropriate so the feature survives release/package generation.nnVerdict: REQUEST_CHANGES
Addresses PR nextlevelbuilder#300 review feedback from @mrgoonie. Changes: - Move cognitive-law audit content from .claude/skills/ui-ux-pro-max/SKILL.md to src/ui-ux-pro-max/templates/base/skill-content.md (source of truth) - Sync updated template to cli/assets/templates/ for npm distribution - Regenerate .claude/skills/ui-ux-pro-max/SKILL.md from canonical template This ensures changes persist across regeneration and propagate to all platform templates via the CLI installer. Audit mode provides: - Phase 1: Fast Pass yes/no gate (9 criteria) - Phase 2: Theory diagnosis mapping to 15 UX principles - Structured output format for fix plans with measurable criteria
✅ Changes Relocated to Canonical Source TemplateI've addressed the review feedback by moving the cognitive-law audit content to the proper source-of-truth location. What ChangedBefore (❌ Wrong location):
After (✅ Correct location):
Changes now:
Content SummaryThe cognitive-law audit mode adds structured UX quality gates:
Ready for re-review. 🚀 |
Summary
ui-ux-pro-max
Test plan
SKILL.mdparses and remains valid markdown.claude/skills/ui-ux-pro-max/SKILL.md