Skip to content

Add cognitive-law audit mode to ui-ux-pro-max skill - #300

Open
Jacobinwwey wants to merge 2 commits into
nextlevelbuilder:mainfrom
Jacobinwwey:pr/human-centered-audit-mode
Open

Add cognitive-law audit mode to ui-ux-pro-max skill#300
Jacobinwwey wants to merge 2 commits into
nextlevelbuilder:mainfrom
Jacobinwwey:pr/human-centered-audit-mode

Conversation

@Jacobinwwey

Copy link
Copy Markdown

Summary

ui-ux-pro-max

  • Add a dedicated cognitive-law audit mode for human-centered UX reviews
  • Introduce a two-phase review workflow:
    • Fast pass yes/no gate for release readiness
    • Theory diagnosis mapped to core UX/cognitive principles
  • Add a standardized reporting format for failure diagnosis and measurable fix plans

Test plan

  • Confirm SKILL.md parses and remains valid markdown
  • Verify new section is present under .claude/skills/ui-ux-pro-max/SKILL.md

@mrgoonie mrgoonie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: The cognitive-law audit checklist is a useful UX-review addition, but this PR edits only the installed Claude skill copy instead of the repo's canonical source template. As submitted, the change can be lost on regeneration and will not propagate to packaged CLI assets or other platform templates.nnRisk level: MediumnnMandatory gates:n- Duplicate/prior implementation: clear — no existing cognitive-law/human-centered audit section or overlapping issue/PR found.n- Project standards: issue found — CLAUDE.md defines src/ui-ux-pro-max/ as the source of truth, with templates edited under src/ui-ux-pro-max/templates/ and then synced to cli/assets.n- Strategic necessity: clear value — a structured UX audit mode fits the skill's review/quality-gate purpose.n- CI/checks: missing/not required for the metadata-only change.nnFindings:n- Important: The PR changes only .claude/skills/ui-ux-pro-max/SKILL.md, while CLAUDE.md says src/ui-ux-pro-max/ is the source of truth and template changes belong in src/ui-ux-pro-max/templates/. Please move this audit-mode content into the canonical template, then regenerate/sync the derived .claude skill and cli/assets template copies as appropriate so the feature survives release/package generation.nnVerdict: REQUEST_CHANGES

@mrgoonie mrgoonie added agent:github-maintain Processed by github-maintain automation pr:reviewed PR reviewed by maintain workflow pr:changes-requested Maintain review requested changes labels Jun 21, 2026
Addresses PR nextlevelbuilder#300 review feedback from @mrgoonie.

Changes:
- Move cognitive-law audit content from .claude/skills/ui-ux-pro-max/SKILL.md
  to src/ui-ux-pro-max/templates/base/skill-content.md (source of truth)
- Sync updated template to cli/assets/templates/ for npm distribution
- Regenerate .claude/skills/ui-ux-pro-max/SKILL.md from canonical template

This ensures changes persist across regeneration and propagate to all
platform templates via the CLI installer.

Audit mode provides:
- Phase 1: Fast Pass yes/no gate (9 criteria)
- Phase 2: Theory diagnosis mapping to 15 UX principles
- Structured output format for fix plans with measurable criteria
@Jacobinwwey

Jacobinwwey commented Jun 21, 2026

Copy link
Copy Markdown
Author

✅ Changes Relocated to Canonical Source Template

I've addressed the review feedback by moving the cognitive-law audit content to the proper source-of-truth location.

What Changed

Before (❌ Wrong location):

  • Edited only .claude/skills/ui-ux-pro-max/SKILL.md (generated file)

After (✅ Correct location):

  • Added content to src/ui-ux-pro-max/templates/base/skill-content.md (canonical source)
  • Synced to cli/assets/templates/base/skill-content.md (npm distribution)
  • Regenerated .claude/skills/ui-ux-pro-max/SKILL.md from source template

Changes now:

  • ✅ Persist across regeneration
  • ✅ Propagate to all 15+ platform templates via CLI installer
  • ✅ Appear in npm package for new installations
  • ✅ Follow documented sync workflow

Content Summary

The cognitive-law audit mode adds structured UX quality gates:

  • Phase 1: Fast Pass (9 yes/no gate checks for release readiness)
  • Phase 2: Theory Diagnosis (maps failures to 15 UX principles: Fitts, Hick, Gestalt family, Von Restorff, Jakob, Miller, Goal-Gradient, Zeigarnik, Tesler, Peak-End, Postel, Doherty, Serial Position, Occam, Parkinson)
  • Output Format: Fast-pass failures only → Principle-to-issue mapping → Fix plans with measurable criteria

Ready for re-review. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:github-maintain Processed by github-maintain automation pr:changes-requested Maintain review requested changes pr:reviewed PR reviewed by maintain workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants