Replace semantic tokens with Andritz Material Design surface hierarchy - #254
Open
Xuu-an wants to merge 1 commit into
Open
Replace semantic tokens with Andritz Material Design surface hierarchy#254Xuu-an wants to merge 1 commit into
Xuu-an wants to merge 1 commit into
Conversation
…hierarchy Introduces Andritz-branded semantic token specification with Material Design surface hierarchy supporting light/dark themes, including ghost borders, No-Line Rule, extreme whitespace spacing, and industrial typography semantics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
mrgoonie
requested changes
Jun 24, 2026
mrgoonie
left a comment
mrgoonie
left a comment
Contributor
There was a problem hiding this comment.
Summary: this PR is part of a larger Andritz design-system rewrite, but by itself it replaces only the installed Claude design-system reference file and leaves the design-system source-of-truth inconsistent.
Risk level: Medium
Mandatory gates:
- Duplicate/prior implementation: overlap found — #251, #255, #256, and #320 are all open Andritz design-system/token rewrites that need one coherent direction.
- Project standards: issue found — repo guidance says source data/templates live under `src/ui-ux-pro-max/`; this PR edits only `.claude/skills/design-system/references/semantic-tokens.md`.
- Strategic necessity: questionable as submitted — Andritz-specific tokens may be useful as a dedicated brand/system pack, but replacing the generic semantic-token reference globally changes the design-system skill into one customer/brand-specific guide.
- CI/checks: missing/not reported.
Findings:
- Important: This changes only `.claude/skills/design-system/references/semantic-tokens.md`, while the repo's sync rules describe `src/ui-ux-pro-max/` as the canonical source-of-truth and `.claude/` as a generated/symlinked skill area. If this is intended to change shipped design-system guidance, please move the change to the canonical source/template path or document why this skill reference is intentionally standalone.
- Important: The PR globally replaces generic semantic-token guidance with Andritz-specific rules and token names, but there are multiple overlapping Andritz PRs (#251, #255, #256, #320). Please consolidate or clearly position this PR as one narrow slice of the chosen Andritz design-system direction so maintainers do not merge conflicting token architectures.
Verdict: REQUEST_CHANGES
mrgoonie
added
agent:github-maintain
This was referenced Jun 24, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:root) and dark (.dark) theme support with 6-level surface hierarchyTest plan
🤖 Generated with Claude Code