Update UI/UX Pro Max skill: expand stacks, localize docs, refine icons - #230
Update UI/UX Pro Max skill: expand stacks, localize docs, refine icons#230goutamKbiswas wants to merge 1 commit into
Conversation
Updates frontmatter to 67 styles, 161 palettes, 57 font pairings, 25 charts, 16 stacks; refreshes quick-reference and skill-content from current templates. https://claude.ai/code/session_018Ph6LxfYWY7mggbneCZHfU
mrgoonie
left a comment
There was a problem hiding this comment.
Summary: This PR updates the main ui-ux-pro-max skill metadata and docs to advertise expanded stack/style coverage and adjust icon guidance. The stack-count update is partially grounded in current source data, but the PR also translates core skill-selection guidance to Chinese and removes Google Fonts lookup references without updating the underlying scripts/data contract.
Risk level: Medium
Mandatory gates:
- Duplicate / prior implementation: overlap found — PR #236 has the same title/scope and was already reviewed with changes requested. This PR is the smaller overlapping variant, so it should not be merged independently without reconciling which branch is canonical.
- Project standards: docs found —
CLAUDE.mdand existing skill docs show English-first skill instructions and source-data-driven behavior. - Strategic necessity: questionable — keeping metadata current is useful, but changing the primary runtime instructions' language and documented query domains creates maintenance/support risk.
Findings:
Important
-
The PR localizes the primary
When to Apply,Must Use,Recommended, and scenario guidance from English to Chinese. These sections are part of the public skill instructions used by all consumers, not locale-specific docs. This makes the canonical skill harder to use for the repo's current English-first audience and introduces a mixed-language instruction surface without adding a locale mechanism. Please keep the canonical skill instructions in English; if Chinese docs are desired, add a separate localized document or explicit i18n structure. -
The PR removes documented
google-fontslookup entries from SKILL.md, but the repo still exposes typography/font lookup behavior in the current skill contract and data model. Removing the documented domain without a matching source/script migration creates a doc/tool contract mismatch for users who rely on font search examples. Either keep the documentation until the domain is actually removed from the shipped data/scripts, or make the full removal coherently across source, packaged assets, docs, and tests. -
Scope overlaps PR #236 (
Update UI/UX Pro Max skill: expand stacks, localize docs, refine icons), which is still open and already has requested changes. Please reconcile/close one branch or narrow this PR to a non-overlapping subset before merge so maintainers don't review and merge conflicting variants of the same doc rewrite.
Verdict: Request changes
Posted by /ck:review-pr at 2026-06-25T00:00:00Z
Summary
Updated the UI/UX Pro Max skill documentation to reflect expanded technology stack support, localize key sections to Chinese, and clarify icon library recommendations with better guidance on fallbacks.
Key Changes
@phosphor-icons/react) as the default icon librarygoogle-fontsdomain from search examples and domain list as it's no longer actively maintainedImplementation Details
https://claude.ai/code/session_018Ph6LxfYWY7mggbneCZHfU