Skip to content

Update UI/UX Pro Max skill: expand stacks, localize docs, refine icons - #230

Open
goutamKbiswas wants to merge 1 commit into
nextlevelbuilder:mainfrom
goutamKbiswas:claude/install-ui-ux-skill-rrqZx
Open

Update UI/UX Pro Max skill: expand stacks, localize docs, refine icons#230
goutamKbiswas wants to merge 1 commit into
nextlevelbuilder:mainfrom
goutamKbiswas:claude/install-ui-ux-skill-rrqZx

Conversation

@goutamKbiswas

Copy link
Copy Markdown

Summary

Updated the UI/UX Pro Max skill documentation to reflect expanded technology stack support, localize key sections to Chinese, and clarify icon library recommendations with better guidance on fallbacks.

Key Changes

  • Expanded technology stack support: Increased from 10 to 16 supported stacks by adding Astro, Nuxt, Nuxt UI, Jetpack Compose, Three.js, and Angular
  • Updated style count: Increased from 50+ to 67 styles to reflect expanded design pattern coverage
  • Localized documentation: Translated critical sections ("When to Apply", "Rule Categories", "Usage Scenarios") to Chinese for better accessibility to Chinese-speaking users
  • Clarified icon library guidance:
    • Specified Phosphor (@phosphor-icons/react) as the default icon library
    • Added explicit fallback strategy to use Heroicons when Phosphor lacks suitable options
    • Emphasized maintaining visual consistency across icon libraries
  • Removed outdated references: Eliminated google-fonts domain from search examples and domain list as it's no longer actively maintained
  • Minor formatting improvements: Fixed markdown heading levels and removed unnecessary blank lines for consistency

Implementation Details

  • Icon library recommendations now include practical guidance on when and how to use alternative libraries while maintaining design coherence
  • Documentation maintains backward compatibility while expanding scope to modern frameworks (Astro, Nuxt, Jetpack Compose, Three.js)
  • Bilingual documentation approach preserves English content while adding Chinese translations for key decision-making sections

https://claude.ai/code/session_018Ph6LxfYWY7mggbneCZHfU

Updates frontmatter to 67 styles, 161 palettes, 57 font pairings, 25 charts,
16 stacks; refreshes quick-reference and skill-content from current templates.

https://claude.ai/code/session_018Ph6LxfYWY7mggbneCZHfU

@mrgoonie mrgoonie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This PR updates the main ui-ux-pro-max skill metadata and docs to advertise expanded stack/style coverage and adjust icon guidance. The stack-count update is partially grounded in current source data, but the PR also translates core skill-selection guidance to Chinese and removes Google Fonts lookup references without updating the underlying scripts/data contract.

Risk level: Medium

Mandatory gates:

  • Duplicate / prior implementation: overlap found — PR #236 has the same title/scope and was already reviewed with changes requested. This PR is the smaller overlapping variant, so it should not be merged independently without reconciling which branch is canonical.
  • Project standards: docs found — CLAUDE.md and existing skill docs show English-first skill instructions and source-data-driven behavior.
  • Strategic necessity: questionable — keeping metadata current is useful, but changing the primary runtime instructions' language and documented query domains creates maintenance/support risk.

Findings:

Important

  1. The PR localizes the primary When to Apply, Must Use, Recommended, and scenario guidance from English to Chinese. These sections are part of the public skill instructions used by all consumers, not locale-specific docs. This makes the canonical skill harder to use for the repo's current English-first audience and introduces a mixed-language instruction surface without adding a locale mechanism. Please keep the canonical skill instructions in English; if Chinese docs are desired, add a separate localized document or explicit i18n structure.

  2. The PR removes documented google-fonts lookup entries from SKILL.md, but the repo still exposes typography/font lookup behavior in the current skill contract and data model. Removing the documented domain without a matching source/script migration creates a doc/tool contract mismatch for users who rely on font search examples. Either keep the documentation until the domain is actually removed from the shipped data/scripts, or make the full removal coherently across source, packaged assets, docs, and tests.

  3. Scope overlaps PR #236 (Update UI/UX Pro Max skill: expand stacks, localize docs, refine icons), which is still open and already has requested changes. Please reconcile/close one branch or narrow this PR to a non-overlapping subset before merge so maintainers don't review and merge conflicting variants of the same doc rewrite.

Verdict: Request changes

Posted by /ck:review-pr at 2026-06-25T00:00:00Z

@mrgoonie mrgoonie added agent:github-maintain Processed by github-maintain automation pr:changes-requested Maintain review requested changes pr:reviewed PR reviewed by maintain workflow labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:github-maintain Processed by github-maintain automation pr:changes-requested Maintain review requested changes pr:reviewed PR reviewed by maintain workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants