Repository navigation
fix(ci): invoke the MCP Worker deployment script explicitly - #11
Merged
Merged
Conversation
mrgoonie
commented
Sep 12, 2026
mrgoonie
left a comment
Contributor
Author
There was a problem hiding this comment.
Summary: Explicitly execute the package deployment script so pnpm does not use its built-in deployment command.
Risk level: Low.
Findings: No Critical or Important issues. The controller independently reviewed all four command edits and confirmed the cause-aligned fix. No runtime, credential or binding changes.
Verdict: Approve. Posted as COMMENT because this account owns the PR.
Posted by the installed review-pr skill at 2026-09-12T08:47:52Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end work summary
Fixes the first production MCP deployment attempt after #10. pnpm treated
deployas its built-in packaging command and failed before invoking Wrangler; explicitly userun deployto execute the package script.Subagent delegation
Controller and toolkit shipping agent reviewed the original workflow; this correction is handled by the toolkit agent. No additional agents.
Technical decisions
Use the existing package script and existing Cloudflare credentials/configuration. No runtime or authorization changes.
Deviations from plan
Follow-up for deterministic deployment failure in run 34684062546.
Completion evidence
ERR_PNPM_INVALID_DEPLOY_TARGET This command requires one parameter.deploytowrangler deploy.run deployin CI and documented manual commands.git diff --checkpassed. Original full suite 113/113 and all nine main CI jobs passed at d710002.Checklist
Human actions required
None for Worker deployment. npm publication remains separately blocked by registry credentials.
Linked Issues
Relates to #9 and #10.
Ship Mode
Official; target main; English default.