Skip to content

fix: correctly handle files sidebar integration - #3047

Merged
sorbaugh merged 3 commits into
masterfrom
fix/sidebar
Jan 16, 2026
Merged

fix: correctly handle files sidebar integration#3047
sorbaugh merged 3 commits into
masterfrom
fix/sidebar

Conversation

@susnux

@susnux susnux commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Note that the sidebar will not open currently without this merged in server: nextcloud/server#57393


Bildschirmaufnahme_20260107_001019.webm

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Jan 6, 2026
@susnux susnux added this to the Nextcloud 33 milestone Jan 6, 2026
@susnux

susnux commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

/compile

@szaimen

szaimen commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

@susnux I just tested this together with nextcloud/server#57393 and seems like I ran into some troubles under special circumstances (sometimes the sidebar does not seem to work):
image

@susnux

susnux commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

What workflow did you test? Because I was not able to find a way to trigger this issue

@susnux

susnux commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

But anyways this is then a problem to be solved in nextcloud/server#57393 :)
Thank you for the feedback

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃悩

@szaimen

szaimen commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

But anyways this is then a problem to be solved in nextcloud/server#57393 :) Thank you for the feedback

Actually I tested together with that but maybe my testing was incorrect

@max-nextcloud

Copy link
Copy Markdown
Contributor

What workflow did you test? Because I was not able to find a way to trigger this issue

I was able to trigger it. I think you need to try with a space character in the file name. The source has %-encoding, while the nodes in the store do not:

grafik Bildschirmfoto vom 2026-01-08 10-36-19

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewer is still using legacy FileInfo - so source is urlencoded, which it is not in server leading to issues with files with whitespace.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with whitespace in the file and dir name.

@max-nextcloud

max-nextcloud commented Jan 15, 2026

Copy link
Copy Markdown
Contributor
grafik Sidebar tests failing a likely related. (Runner 1)

@susnux

susnux commented Jan 15, 2026

Copy link
Copy Markdown
Contributor Author

Sidebar tests failing a likely related. (Runner 1)

yes because they need the server PR

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@max-nextcloud

Copy link
Copy Markdown
Contributor

Restarted cypress now that the server PR has been merged.

@sorbaugh
sorbaugh merged commit 6deeede into master Jan 16, 2026
34 of 51 checks passed
@sorbaugh
sorbaugh deleted the fix/sidebar branch January 16, 2026 08:49
susnux pushed a commit that referenced this pull request May 16, 2026
fix: correctly handle files sidebar integration
susnux pushed a commit that referenced this pull request May 16, 2026
fix: correctly handle files sidebar integration
susnux pushed a commit that referenced this pull request May 16, 2026
fix: correctly handle files sidebar integration
susnux pushed a commit that referenced this pull request May 16, 2026
fix: correctly handle files sidebar integration
susnux pushed a commit that referenced this pull request May 16, 2026
fix: correctly handle files sidebar integration
susnux pushed a commit that referenced this pull request May 16, 2026
fix: correctly handle files sidebar integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open sidebar menu entry is gone in main branch

4 participants