Skip to content

feat: Viewer 7.0.0 - #2989

Open
skjnldsv wants to merge 4 commits into
masterfrom
feat/6.0.0
Open

feat: Viewer 7.0.0#2989
skjnldsv wants to merge 4 commits into
masterfrom
feat/6.0.0

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Oct 9, 2025

Copy link
Copy Markdown
Member

WIP → nearing completion.

Steps

  • Cleanup and move to vite
  • Extend api package with new APIs
  • Implement Web components (custom-element handlers)
  • Migrate core Modal (NcModal)
  • Wrap old components

Done in this update

  • Image and Audio components migrated (Video already done)
  • Actions menu via file-action API (default open + "Open with …" selector)
  • In-modal actions menu linked to the Files actions (download/delete/…) + internal Edit — fixes Files actions #7
  • openFolder API
  • compare API (side-by-side)
  • e2e + unit tests: Cypress → Vitest (127) + Playwright
  • Addressed TODO comments / dead code
  • Rebased onto master (squashed to clean commits)
  • api_package README updated to the new handler API

Still to do

  • Run the Playwright suite against a live server (needs Docker)
  • Manual QA: zoom/pan, live photos, compare, sidebar
  • Follow-up: upstream the enabled/sort file-action filtering into @nextcloud/files

Fixes

AI

  • The content of this PR was partly generated using AI (Claude Code); every commit carries an Assisted-by trailer.

@skjnldsv skjnldsv added this to the Nextcloud 33 milestone Oct 9, 2025
@skjnldsv skjnldsv self-assigned this Oct 9, 2025
@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress labels Oct 9, 2025
@skjnldsv
skjnldsv force-pushed the feat/6.0.0 branch 2 times, most recently from a4377d7 to 22bc3b5 Compare November 21, 2025 17:03
@susnux susnux changed the title feat: Viewer 6.0.0 feat: Viewer 7.0.0 Dec 30, 2025
@susnux susnux modified the milestones: Nextcloud 33, Nextcloud 34 Dec 30, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 34, Nextcloud 35 Jun 5, 2026
@skjnldsv skjnldsv modified the milestones: Nextcloud 35, Nextcloud 36 Aug 28, 2026
@skjnldsv
skjnldsv force-pushed the feat/6.0.0 branch 3 times, most recently from 7a3ca92 to 5d90b8b Compare August 28, 2026 14:19
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Assisted-by: ClaudeCode:claude-opus-4-8
@skjnldsv
skjnldsv force-pushed the feat/6.0.0 branch 11 times, most recently from b92cedc to 6d5d305 Compare September 2, 2026 11:41
Replace the Cypress suite with Vitest (unit + component) and a Playwright
end-to-end suite that runs against a live Nextcloud container, wire the
corresponding CI workflows, and share the event-bus/viewer mocks via manual
mocks.

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Assisted-by: ClaudeCode:claude-opus-4-8
Rewrite the viewer to Vue 3 + Vite with a framework-agnostic custom-element
handler API (@nextcloud/viewer), a new open/openFolder/compare API and
file-action integration.

History (openfile/editing URL params) keeps a refresh reopening the same state;
editing is only reopened on a genuine deeplink so a fresh open never inherits a
stale editing flag. The viewer menu mirrors the Files actions, rename opens an
in-viewer dialog, delete advances then closes, the sidebar fills the full
height, and image editing uses @nextcloud/image-editor (beta.2) at the viewer
level, showing the saved blob without a refetch.

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Assisted-by: ClaudeCode:claude-opus-4-8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files actions

3 participants