Emit a TokenRefreshedEvent when the login token is refreshed - #1517
Merged
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/token-refresh-event
branch
from
September 1, 2026 09:00
90c7b83 to
599052e
Compare
CarlSchwan
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, if
store_login_tokenis enabled, other apps can request a valid login token when they need it by emittingExternalTokenRequestedEvent.But in some cases, they might want to only get it once and know when it is refreshed.
So they can listen to the existing
TokenObtainedEventto get the login token when the user is logging in and listen to the newTokenRefreshedEventto get the refreshed token only once, when it is obtained.This could be convenient if an app wants to store the token instead of accessing it everytime they need it.
This should not have any annoying side effect.
🤖 AI (if applicable)