Skip to content

fix: harden redirecting after login #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 1 commit into from
Sep 1, 2026
Merged

fix: harden redirecting after login #1514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/Controller/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,20 @@ private function buildProtocolErrorResponse(?bool $throttle = null): TemplateRes
* @return RedirectResponse
*/
private function getRedirectResponse(?string $redirectUrl = null): RedirectResponse {
$baseUrl = $this->urlGenerator->getBaseUrl();

if ($redirectUrl === null) {
return new RedirectResponse($this->urlGenerator->getBaseUrl());
return new RedirectResponse($baseUrl);
}

// Remove protocol and domain name
$filtered = preg_replace('/^https?:\/\/[^\/]+/', '', $redirectUrl) ?? '';

// Additional check: ensure the result starts with a single /
if (!preg_match('/^\/[^\/]/', $filtered)) {
return new RedirectResponse($this->urlGenerator->getBaseUrl());
// Reject protocol-relative URLs and anything not starting with a single slash followed
// by an alphanumeric or one of [_-.~?#]
if (!preg_match('/^\/[A-Za-z0-9_\-.~?#]/', $filtered)) {
$this->logger->error("Rejected invalid redirect url '{$filtered}'");
return new RedirectResponse($baseUrl);
}

return new RedirectResponse($filtered);
Expand Down
Loading