feat(user_oidc): Add provider_id/sub columns and getByProviderAndSub() - #1498
Merged
Conversation
come-nc
reviewed
Aug 24, 2026
come-nc
reviewed
Aug 24, 2026
come-nc
approved these changes
Aug 24, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Good apart from above nitpick
Store the provider and OIDC subject claim a user was provisioned from alongside the (possibly hashed) user_id, and look accounts up by this (provider_id, sub) pair first in getOrCreate(). This keeps a provider's own attribute drift (e.g. the mapped uid attribute changing) from forking the account into a second, empty one. Existing rows are backfilled opportunistically on next login, since the original sub is not recoverable from a one-way hashed user_id. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the provider and OIDC subject claim a user was provisioned from alongside the (possibly hashed) user_id, and look accounts up by this (provider_id, sub) pair first in getOrCreate(). This keeps a provider's own attribute drift (e.g. the mapped uid attribute changing) from forking the account into a second, empty one.
Existing rows are backfilled opportunistically on next login, since the original sub is not recoverable from a one-way hashed user_id.
🤖 AI (if applicable)