feat: Use new IAlternativeLoginProvider when available - #1413
Merged
Conversation
CarlSchwan
force-pushed
the
carl/alternative-login-provider
branch
2 times, most recently
from
April 14, 2026 14:24
f853751 to
4177baa
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/alternative-login-provider
branch
from
April 14, 2026 14:27
4177baa to
77c2867
Compare
artonge
approved these changes
Apr 14, 2026
artonge
left a comment
artonge
left a comment
Contributor
There was a problem hiding this comment.
Request for a comment, else, looks good
| $providers = $this->getCachedProviders($providerMapper); | ||
| $customLoginLabel = $config->getSystemValue('user_oidc', [])['login_label'] ?? ''; | ||
| foreach ($providers as $provider) { | ||
| // FIXME: Move to IAlternativeLogin but requires boot due to db connection |
Contributor
There was a problem hiding this comment.
Would add a comment stating that we can remove it once we drop support for NC33 or bellow.
…rename getAlternativeLogin to getAlternativeLogins Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…tiveLogin is used Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
carl/alternative-login-provider
branch
from
April 15, 2026 10:37
1fbd299 to
7e38ede
Compare
julien-nc
approved these changes
Apr 15, 2026
julien-nc
left a comment
julien-nc
left a comment
Member
There was a problem hiding this comment.
Nice! No more hacks needed to register multiple ones with IAlternativeLogin! 💙
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextcloud/server#59627