Skip to content

fix(gss): Improve error logging for JWT decode failures in SLS #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 1 commit into from
Mar 18, 2026
Merged

fix(gss): Improve error logging for JWT decode failures in SLS #1374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/Controller/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,8 +729,14 @@ public function singleLogoutService() {
$decoded = (array)JWT::decode($jwt, new Key($key, 'HS256'));

$providerId = $decoded['oidcProviderId'] ?? null;
} catch (\DomainException $e) {
$this->logger->error(
'Failed to decode GSS JWT: ' . $e->getMessage()
. '. If the key is too short, gss.jwt.key must be at least 32 characters for HS256 (per RFC 7518).',
['exception' => $e]
);
} catch (\Exception $e) {
$this->logger->debug('Failed to get the logout provider ID in the request from GSS', ['exception' => $e]);
$this->logger->error('Failed to decode GSS JWT in single logout', ['exception' => $e]);
}
} else {
$providerId = $this->session->get(self::PROVIDERID);
Expand Down
Loading