perf(cleanup): Optimize cleanup job - #9166
Draft
Koc wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
commented
Sep 3, 2026
Comment on lines
-37
to
+42
| $this->attachmentService->cleanupAttachments($document->getId()); | ||
| $documentId = $document->getId(); | ||
| try { | ||
| $this->documentService->resetDocument($documentId); |
Author
There was a problem hiding this comment.
need to investigate why resetDocument was removed before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃摑 Summary
馃毀 WIP
This is continuation of the #8421.
Problem:
The text app cleanup background job took roughly 800 seconds per run. The loop over documents with no active session unconditionally called
cleanupAttachments, even for documents that had unsaved changes and could not be reset. The same ~8,000 documents kept re-entering the cleanup loop every cron run, andcleanupAttachmentsis expensive because it resolves the file, reads Markdown content, scans the database, and iterates the attachment directory.Solution:
resetDocumentbefore runningcleanupAttachments.DocumentHasUnsavedChangesException:Impact:
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)