fix(collaboration): override addProseMirrorPlugins to prevent default caret user - #9160
Open
benjaminfrueh wants to merge 1 commit into
Open
fix(collaboration): override addProseMirrorPlugins to prevent default caret user#9160benjaminfrueh wants to merge 1 commit into
benjaminfrueh wants to merge 1 commit into
Conversation
… caret user Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
Contributor
Author
|
/backport to stable35 |
max-nextcloud
approved these changes
Sep 2, 2026
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Code changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes the collaborator cursor showing a id (e.g.
User: 123) instead of the actual name in stable35.What happened
Tiptap sets its own default user when the caret feature is setup. Since a recent tiptap update (>= 3.24.0), which we use now with stable35, this happens later and ends up overwriting the name we set.
Fix
Override tiptap's
addProseMirrorPluginsin our caret extension so it no longer sets a default user, leaving our user data as the only source.Related tiptap commit which introduced this incompatibility:
ueberdosis/tiptap@976b8e3
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)