Skip to content

fix(collaboration): override addProseMirrorPlugins to prevent default caret user - #9160

Open
benjaminfrueh wants to merge 1 commit into
mainfrom
fix/caret-user
Open

fix(collaboration): override addProseMirrorPlugins to prevent default caret user#9160
benjaminfrueh wants to merge 1 commit into
mainfrom
fix/caret-user

Conversation

@benjaminfrueh

@benjaminfrueh benjaminfrueh commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📝 Summary

Fixes the collaborator cursor showing a id (e.g. User: 123) instead of the actual name in stable35.

What happened

Tiptap sets its own default user when the caret feature is setup. Since a recent tiptap update (>= 3.24.0), which we use now with stable35, this happens later and ends up overwriting the name we set.

Fix

Override tiptap's addProseMirrorPlugins in our caret extension so it no longer sets a default user, leaving our user data as the only source.

Related tiptap commit which introduced this incompatibility:
ueberdosis/tiptap@976b8e3

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

… caret user

Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
@benjaminfrueh benjaminfrueh added the bug Something isn't working label Sep 2, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Sep 2, 2026
@benjaminfrueh benjaminfrueh moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Sep 2, 2026
@benjaminfrueh

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants