Skip to content

[stable35] fix/no conflicts on sync - #9157

Merged
mejo- merged 3 commits into
stable35from
backport/9149/stable35
Sep 2, 2026
Merged

[stable35] fix/no conflicts on sync#9157
mejo- merged 3 commits into
stable35from
backport/9149/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Backport of #9149

Warning, This backport's changes differ from the original and might be incomplete 鈿狅笍

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

The document may be in the middle of getting saved.

When the file has been updated
but the metadata in the documents table has not
it may seem like the file was overwritten
even though text is saving the file.

This does not indicate an actual conflict.
Avoid triggering the conflict screen in that race condition.

Signed-off-by: Max <max@nextcloud.com>
We observed save requests that took longer than 30 seconds.
The lock needs to outlive those in order to prevent superfluous 409 responses.

Signed-off-by: Max <max@nextcloud.com>
fix(save): autosave only every ten seconds

Abort autosave if another save is still under way.

We observed save requests taking up to 30 seconds.

In this timespan autosave requests would still be processed

as the lastSavedTime in the database has not been updated yet.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
max-nextcloud marked this pull request as ready for review September 2, 2026 05:19
@mejo-
mejo- merged commit 7c00374 into stable35 Sep 2, 2026
72 of 75 checks passed
@mejo-
mejo- deleted the backport/9149/stable35 branch September 2, 2026 06:51
@mejo-

mejo- commented Sep 2, 2026

Copy link
Copy Markdown
Member

/backport to stable34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants