Skip to content

Fix link bubble behaviour #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
As3r1408 wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −6
Open

Fix link bubble behaviour #9156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff6ec7c
Fix link bubble behaviour
As3r1408 Sep 2, 2026
69b5f5c
Merge branch 'main' into fix-link-bubble-clean
As3r1408 Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/components/Editor/PreviewOptions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
-->
<template>
<NcActions
ref="actions"
v-model="open"
data-text-link-options="select"
class="link-options"
Expand All @@ -16,15 +17,15 @@
data-text-preview-option="text-only"
name="preview-option"
value="text-only"
:modelValue="type"
:modelValue="selectedType"
@change="(e) => toggle(e.currentTarget.value)">
{{ t('text', 'Text only') }}
</NcActionRadio>
<NcActionRadio
data-text-preview-option="link-preview"
name="preview-option"
value="link-preview"
:modelValue="type"
:modelValue="selectedType"
@change="(e) => toggle(e.currentTarget.value)">
{{ t('text', 'Show link preview') }}
</NcActionRadio>
Expand Down Expand Up @@ -116,6 +117,7 @@ export default {
data() {
return {
open: false,
selectedType: this.type,
}
},

Expand All @@ -125,13 +127,21 @@ export default {
},
},

watch: {
type(value) {
this.selectedType = value
},

},

methods: {
onOpen() {
this.$emit('open')
},

toggle(type) {
this.open = false
async toggle(type) {
this.selectedType = type
await this.$refs.actions?.closeMenu(false)
this.$emit('toggle', type)
},

Expand Down
13 changes: 11 additions & 2 deletions src/plugins/links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ export function linkBubble(options: { editor: Editor }) {
) {
return false
}

// Only show the link bubble while editing.
if (!view.editable) {
return false
}
const { state, dispatch } = view
const resolved = state.doc.resolve(pos)
return setActiveLink(resolved)(state, dispatch)
Expand Down Expand Up @@ -184,6 +189,10 @@ export function linkClicking(openLink: (href: string) => void = (href) => {
}

if (event.button === 0) {
// In editing mode, let the link bubble handle the click
if (view.editable && !event.ctrlKey && !event.metaKey) {
return false
}
// Stop browser from opening the link
event.preventDefault()

Expand All @@ -196,8 +205,8 @@ export function linkClicking(openLink: (href: string) => void = (href) => {
target?.scrollIntoView({ block: 'start', behavior: 'smooth' })
}
window.history.replaceState({}, '', url.href)
} else if (event.ctrlKey || event.metaKey) {
// Open link directly on Ctrl/Cmd + left click
} else {
// Open link directly on left click
openLink(linkEl.href)
}
}
Expand Down
Loading