fix(conversationlist): avoid blocking main thread in onResume, causin… - #6684
Merged
Conversation
…g ANR blockingGet() on userManager.users in onResume() forced the main thread to wait on the SQLCipher connection pool, which background WorkManager jobs (CapabilitiesWorker, AccountRemovalWorker) were contending for at the same time, leading to an ANR. Fetch the account count asynchronously via lifecycleScope + await() instead. The same blockingGet() pattern exists in several other places in this class and elsewhere touching the DB/network synchronously from the main thread; those are lower risk since they're not in the onResume hot path, but are worth revisiting if similar ANRs show up. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Collaborator
Author
|
/backport to stable-25.0.x |
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/34458423628/artifacts/10144886063 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g ANR
blockingGet() on userManager.users in onResume() forced the main thread to wait on the SQLCipher connection pool, which background WorkManager jobs (CapabilitiesWorker, AccountRemovalWorker) were contending for at the same time, leading to an ANR. Fetch the account count asynchronously via lifecycleScope + await() instead.
The same blockingGet() pattern exists in several other places in this class and elsewhere touching the DB/network synchronously from the main thread; those are lower risk since they're not in the onResume hot path, but are worth revisiting if similar ANRs show up.
Assisted-by: Claude Code:claude-sonnet-5
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)