[stable-25.0.x] refactor(conversations): drop the null checks the share dialog makes for itself - #6680
Merged
Merged
Conversation
…for itself ShareCreatedConversation takes nullable arguments and returns early when there is nothing to show, so the guards around it were dead, and they carried CreateConversation past detekt's length limit. Its halves disagreed because the commit that introduced them was split on its way into master. Assisted-by: Claude Code:claude-opus-5 Claude-Session: https://claude.ai/code/session_01BNSsmKY8YJk7MwDYUequef Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
mahibi
approved these changes
Sep 10, 2026
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/34452150765/artifacts/10143064593 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6677