Skip to content

fix(crash): forward original exception instead of secondary handler f… #6640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahibi merged 1 commit into from
Sep 3, 2026
Merged

fix(crash): forward original exception instead of secondary handler f… #6640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/com/nextcloud/talk/errorhandling/ExceptionHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,11 @@ class ExceptionHandler(
}
}
} catch (fatal: Exception) {
// Forward the original crash, not this secondary failure, so crash
// reporting reflects why the app actually died rather than why we
// failed to show the crash screen for it.
Log.e(TAG, "Fatal error in ExceptionHandler itself", fatal)
defaultExceptionHandler.uncaughtException(thread, fatal)
defaultExceptionHandler.uncaughtException(thread, exception)
return
}
// Forward to the default handler so AMS records the crash as REASON_CRASH and
Expand Down
Loading