Skip to content

fix(download): avoid divide by zero when file size is 0 - #6630

Merged
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixFailingDownload
Sep 3, 2026
Merged

fix(download): avoid divide by zero when file size is 0#6630
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixFailingDownload

Conversation

@mahibi

@mahibi mahibi commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

otherwise download failed with error

2026-09-03 09:55:13.8612743-2796WM-WorkerWrappercom.nextcloud.talk2EWork [ id=6044ab54-1b6a-4024-9ed7-09435d65a87e, tags={ com.nextcloud.talk.jobs.DownloadFileToCacheWorker,14053871 } ] failed because it threw an exception/error (Fix with AI) java.lang.ArithmeticException: divide by zero
at
com.nextcloud.talk.jobs.DownloadFileToCacheWorker.executeDownload(DownloadFileToCacheWorker.kt:117) at
com.nextcloud.talk.jobs.DownloadFileToCacheWorker.downloadFile(DownloadFileToCacheWorker.kt:88) at
com.nextcloud.talk.jobs.DownloadFileToCacheWorker.doWork(DownloadFileToCacheWorker.kt:75) at androidx.work.Worker.startWork$lambda$0(Worker.kt:64) at androidx.work.Worker$$ExternalSyntheticLambda0.invoke(D8$$SyntheticClass:0) at androidx.work.WorkerKt.future$lambda$2$lambda$1(Worker.kt:100) at androidx.work.WorkerKt$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0) at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1100) at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:1572)

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

otherwise download failed with error

2026-09-03 09:55:13.8612743-2796WM-WorkerWrappercom.nextcloud.talk2EWork [ id=6044ab54-1b6a-4024-9ed7-09435d65a87e, tags={
com.nextcloud.talk.jobs.DownloadFileToCacheWorker,14053871 } ] failed because it threw an exception/error (Fix with AI)
java.lang.ArithmeticException: divide by zero
at
com.nextcloud.talk.jobs.DownloadFileToCacheWorker.executeDownload(DownloadFileToCacheWorker.kt:117)
at
com.nextcloud.talk.jobs.DownloadFileToCacheWorker.downloadFile(DownloadFileToCacheWorker.kt:88)
at
com.nextcloud.talk.jobs.DownloadFileToCacheWorker.doWork(DownloadFileToCacheWorker.kt:75)
at androidx.work.Worker.startWork$lambda$0(Worker.kt:64)
at androidx.work.Worker$$ExternalSyntheticLambda0.invoke(D8$$SyntheticClass:0)
at androidx.work.WorkerKt.future$lambda$2$lambda$1(Worker.kt:100)
at androidx.work.WorkerKt$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1100)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:1572)

Signed-off-by: Marcel Hibbe <marcel.hibbe@nextcloud.com>
@mahibi mahibi added this to the 25.1.0 milestone Sep 3, 2026
@mahibi mahibi self-assigned this Sep 3, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Sep 3, 2026
@mahibi

mahibi commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-25.0.x

@mahibi
mahibi merged commit 84ef344 into master Sep 3, 2026
14 of 20 checks passed
@mahibi
mahibi deleted the bugfix/noid/fixFailingDownload branch September 3, 2026 08:42
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33732155682/artifacts/9885418307
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant