Skip to content

(fix): Adding google emoji picker to message input fragment - #6623

Merged
mahibi merged 1 commit into
masterfrom
removing_emojipicker_message_input
Sep 3, 2026
Merged

(fix): Adding google emoji picker to message input fragment#6623
mahibi merged 1 commit into
masterfrom
removing_emojipicker_message_input

Conversation

@rapterjet2004

Copy link
Copy Markdown
Contributor
  • view_message_input.xml — smileyButton ImageButton reinstated between the attachment button and the message input (exact historic position/styling, using the pre-existing ic_insert_emoticon_black_24dp drawable).
  • fragment_message_input.xml — EmojiPickerView added below the input row, 250dp tall, hidden by default.
  • MessageInput.kt — exposes smileyButton again.
  • MessageInputFragment.kt — initSmileyKeyboardToggler() restored: toggles between keyboard and emoji picker, swaps the button icon (emoji ↔ keyboard glyph), inserts picked emoji at the cursor, and a MessageInputRecentEmojiProvider persists the last 20 used emoji in SharedPreferences.
  • TalkSpecificViewThemeUtils.kt — themeEmojiPicker() restored, applying dynamic-color theming to the picker background and category tabs via the existing EmojiPickerCategoryTabs.kt helpers.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…n the attachment button and the message input (exact historic position/styling, using the pre-existing ic_insert_emoticon_black_24dp drawable).

- fragment_message_input.xml — EmojiPickerView added below the input row, 250dp tall, hidden by default.
- MessageInput.kt — exposes smileyButton again.
- MessageInputFragment.kt — initSmileyKeyboardToggler() restored: toggles between keyboard and emoji picker, swaps the button icon (emoji ↔ keyboard glyph), inserts picked emoji at the cursor, and a MessageInputRecentEmojiProvider persists the last 20 used emoji in SharedPreferences.
- TalkSpecificViewThemeUtils.kt — themeEmojiPicker() restored, applying dynamic-color theming to the picker background and category tabs via the existing EmojiPickerCategoryTabs.kt helpers.

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
rapterjet2004 requested a review from mahibi September 2, 2026 15:21
@rapterjet2004 rapterjet2004 self-assigned this Sep 2, 2026
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Sep 2, 2026
@mahibi

mahibi commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Hi @nickvergessen @AndyScherzinger @jancborchardt @nimishavijay

@rapterjet2004 implemented this as a suggestion how the google emoji picker could be used..

Before:

no emoji picker in message input (removed with #6443 as discussed in #2735)

After:

grafik grafik

Pro:

  • users still have an emoji icon to insert emojis without to use the built in keyboard emojipicker

Contra:

  • no search feature
  • no backspace button to delete an emoji (at least in the current implementation. users will have to switch to keyboard currently to press the backspace)

What's your opinion?

  1. No emoji picker for message input. User have to use the keyboard emoji feature
  2. Take this emoji picker although it has no search and backspace
  3. invest more time to improve the search feature based on top of this PR, see Emojipicker with search #6624

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33647999359/artifacts/9855928483
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi

mahibi commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

a quick test with claude trying to add the search and backspace button worked quite well. not sure if it's worth it though, waiting for opinions first..
Draft is #6624

@mahibi mahibi mentioned this pull request Sep 2, 2026
7 tasks
@nickvergessen

Copy link
Copy Markdown
Member

No search is a bummer, but I think we should move forward with this topic

@mahibi

mahibi commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

No search is a bummer, but I think we should move forward with this topic

what's moving forward in your opinion? option 1, 2 or 3 ?

  • Joas' answer was "2". So merging it..

@mahibi mahibi added this to the 25.1.0 milestone Sep 3, 2026
@mahibi
mahibi merged commit d249729 into master Sep 3, 2026
15 of 20 checks passed
@mahibi
mahibi deleted the removing_emojipicker_message_input branch September 3, 2026 08:33
@mahibi

mahibi commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

/backport to stable-25.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants