Skip to content

fix(camera): declare photos/ as FileProvider cache path - #6622

Merged
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixToSetPhotoForConversation
Sep 3, 2026
Merged

fix(camera): declare photos/ as FileProvider cache path#6622
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixToSetPhotoForConversation

Conversation

@mahibi

@mahibi mahibi commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Camera capture files are written to cache/photos/camera_capture.jpg, but file_provider_paths.xml only declared shared_attachments/, causing FileProvider.getUriForFile to throw IllegalArgumentException when taking a picture from the conversation info edit screen.

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mahibi mahibi added this to the 25.1.0 milestone Sep 2, 2026
@mahibi mahibi self-assigned this Sep 2, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Sep 2, 2026
Camera capture files are written to cache/photos/camera_capture.jpg,
but file_provider_paths.xml only declared shared_attachments/, causing
FileProvider.getUriForFile to throw IllegalArgumentException when
taking a picture from the conversation info edit screen.

Assisted-by: Claude Code:claude-sonnet-5

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
mahibi force-pushed the bugfix/noid/fixToSetPhotoForConversation branch from 16cdf23 to d51da98 Compare September 2, 2026 14:32
@mahibi

mahibi commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-25.0.x

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33642687444/artifacts/9854345529
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
mahibi requested a review from rapterjet2004 September 3, 2026 06:56
@mahibi
mahibi merged commit e08b218 into master Sep 3, 2026
14 of 20 checks passed
@mahibi
mahibi deleted the bugfix/noid/fixToSetPhotoForConversation branch September 3, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant