[stable-25.0.x] Files permission share options - #6605
Merged
Conversation
Lets the sender choose between view-only and editable when uploading a file into a conversation, mirroring the option added on iOS (nextcloud/talk-ios#2669). Only shown/honoured when the server has conversation subfolders enabled, since that's the only upload path the server can apply the permission to. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Replaces the two-way segmented buttons with compact pill buttons that show the current selection and open a dropdown menu with the alternative, matching the upload option buttons of the iOS share sheet (nextcloud/talk-ios#2669): gray while the option is the default one an upload starts with, filled with the theme color once it isn't. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Media quality: SF Symbols has no SD/HD badges, so the iOS app draws them as text in a bordered box; do the same instead of the unrelated Material "high quality" icons. File permissions: switch from a lock icon to Edit/EditOff, matching the pencil/pencil.slash icons iOS uses. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Editable/original quality no longer switch the button to a filled highlight - it stays the same gray pill as view-only/reduced quality, so only the label and icon change with the selection. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6604