revert isPlausibleLastReadMessageId check - #6571
Merged
Merged
Conversation
Collaborator
Author
|
/backport to stable-25.0.x |
AndyScherzinger
approved these changes
Aug 25, 2026
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/32834728895/artifacts/9559522657 |
Checking the real data for a big instance unveiled i was pretty off with my assumption how high the difference between messageId and newestKnownRealMessageId could be. Logging for C.N.C was: "advanceLocalLastReadMessageIfNeeded, messageId (5748751) is implausibly higher than the conversation's newest known message id (5694085). We won't advance." I wont go down that road to increase PLAUSIBLE_MESSAGE_ID_BUFFER every know and then when it turns out it is still too low. The curretn logic might introduce more problems than it would solve. There should be other checks to make sure readmarkers don't make it to the server when they are wrong. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
AndyScherzinger
force-pushed
the
revertIsPlausibleLastReadMessageChecks
branch
from
August 25, 2026 11:28
c86bd91 to
8bc413c
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/32844907385/artifacts/9564607627 |
AndyScherzinger
enabled auto-merge
August 25, 2026 14:43
AndyScherzinger
disabled auto-merge
August 25, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will revert #6486
Checking the real data for a big instance unveiled i was pretty off with my assumption how high the difference between messageId and newestKnownRealMessageId could be.
Logging for C.N.C was:
"advanceLocalLastReadMessageIfNeeded, messageId (5748751) is implausibly higher than the conversation's newest known message id (5694085). We won't advance."
This seems reasonable but i wont go down that road to increase PLAUSIBLE_MESSAGE_ID_BUFFER every know and then when it turns out it is still too low.
The current logic might introduce more problems than it would solve. There should be other checks to make sure readmarkers don't make it to the server when they are wrong.
馃弫 Checklist
/backport to stable-xx.x馃 AI (if applicable)