[stable-25.0.x] fix(call): detect dead signaling WebSocket connections via ping interval - #6558
Merged
Merged
Conversation
The signaling WebSocket was created from the shared OkHttpClient without a ping interval. In OkHttp 4.x this means no protocol-level pings are sent and the WebSocket read timeout is infinite, so a half-open connection (e.g. after switching from WiFi to cellular without a TCP reset) is never detected: onFailure never fires, the existing reconnect logic never runs, and the call goes silently mute/deaf while participants still appear present. Derive a dedicated client for the signaling WebSocket that pings every 10 seconds. OkHttp now fails the socket when a pong is not received in time, which triggers the existing onFailure -> restartWebSocket path. Regular HTTP calls keep using the unchanged shared client. Assisted-by: opencode:ox-alpha Signed-off-by: Tarek Loubani <tarek@tarek.org>
AndyScherzinger
approved these changes
Aug 24, 2026
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/32740522309/artifacts/9525400111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6543