use application name as user agent - #6401
Conversation
|
/backport to stable-24.0 |
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/28600595098/artifacts/8043539273 |
caa0641 to
9c90d80
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/28608526275/artifacts/8046616136 |
..important for branding Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
9c90d80 to
a54efda
Compare
"testing anonymouslyPostLoginRequest correct path" ❯ ERROR: NetworkLoginDataSource: Error caught at anonymouslyPostLoginRequest: java.lang.NullPointerException junit.framework.AssertionFailedError at junit.framework.Assert.fail(Assert.java:55) at junit.framework.Assert.assertTrue(Assert.java:22) at junit.framework.Assert.assertNotNull(Assert.java:256) at junit.framework.Assert.assertNotNull(Assert.java:248) at junit.framework.TestCase.assertNotNull(TestCase.java:391) at com.nextcloud.talk.login.data.network.NetworkLoginDataSourceTest.testing anonymouslyPostLoginRequest correct path(NetworkLoginDataSourceTest.kt:51) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
|
The backport to # Switch to the target branch and update it
git checkout stable-24.0
git pull origin stable-24.0
# Create the new backport branch
git checkout -b backport/6401/stable-24.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a54efdab e72de223
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6401/stable-24.0Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/6401/stable-24.0') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable-24.0.x |
3 participants
🏁 Checklist
/backport to stable-xx.xHow to test
see http requests in logcat.
For all requests there should be
User-Agent: Mozilla/5.0 (Android) Nextcloud-Talk v24.1.0 Alpha 15Only for the login request there should be
User-Agent: Mozilla/5.0 (Android) Nextcloud Talk v24.1.0 Alpha 15(can also be seen at the login website)so it's "Nextcloud-Talk" vs "Nextcloud Talk".
Seems meaningless when it's the native Nextcloud Talk client, but it's important for branded clients.
🤖 AI (if applicable)