Skip to content

validate password - #5955

Draft
sowjanyakch wants to merge 2 commits into
masterfrom
bugfix/5923/validatePassword
Draft

validate password#5955
sowjanyakch wants to merge 2 commits into
masterfrom
bugfix/5923/validatePassword

Conversation

@sowjanyakch

@sowjanyakch sowjanyakch commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix #5923

  • Validates password and displays a warning when password does not meet the preset configuration.
  • Validates password when creating a conversation and set/reset password from conversation info.
  • Also fixes a bug with the conversation creation where clicking on the conversation options "Allow guests" , "Open conversation to registered users" opens set/change password dialog.
  • Also show an option to copy the password of a conversation both in new conversation creation and conversation info screen.
Screenshot 2026-04-01 at 13 39 38 Screenshot 2026-04-01 at 13 38 29

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@github-actions

github-actions Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5955.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@sowjanyakch
sowjanyakch force-pushed the bugfix/5923/validatePassword branch from 46cd60a to 794b948 Compare April 1, 2026 11:51
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/23847155565/artifacts/6219786615
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@sowjanyakch
sowjanyakch force-pushed the bugfix/5923/validatePassword branch 2 times, most recently from 2dfc70a to a5beaba Compare April 1, 2026 13:52
@sowjanyakch sowjanyakch self-assigned this Apr 1, 2026
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Apr 1, 2026
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/23852178142/artifacts/6222065915
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@sowjanyakch
sowjanyakch force-pushed the bugfix/5923/validatePassword branch from a5beaba to 63add9a Compare May 13, 2026 16:43
@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings8991
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5252
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total7979

Lint increased!

@mahibi

mahibi commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

@sowjanyakch sorry the PR was not reviewed before getting the merge conflicts. Could you try to resolve the conflicts?

@rapterjet2004 rapterjet2004 self-assigned this Sep 2, 2026
@mahibi

mahibi commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

@rapterjet2004 could you try to rescue this PR?

@rapterjet2004
rapterjet2004 marked this pull request as draft September 3, 2026 15:52
@rapterjet2004 rapterjet2004 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 3, 2026
sowjanyakch and others added 2 commits September 3, 2026 11:29
@sowjanyakch @rapterjet2004
add model
05c2ef4 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

add password logic

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

handle states of password states

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

copy password

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

remove unused function and add copyright info

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

modify layout and import changes with the package name change

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

split GuestAccessPasswordDialog into two functions

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>

fix detekt

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@rapterjet2004
fix(guest-access): repair password-policy validation after rebase ont…
3954359 
…o master

The PR was rebased onto a master that had since migrated
ConversationInfo to Jetpack Compose, which broke the build: the merge
resurrected pre-migration files (GuestAccessHelper.kt, its
DialogPasswordBinding/ActivityConversationInfoBinding dialog code) and
dropped an unrelated master fix (@serializable on
ProvisioningCapability).

- Delete GuestAccessHelper.kt (obsolete View/XML-binding helper no
  longer referenced since the Compose migration) and port its
  password-validation dialog into ConversationInfoActivity's Compose
  screen, replacing the stale XML showPasswordDialog().
- Remove dead, unrelated state left over in ConversationInfoViewModel
  from the old base branch (GetCapabilitiesStartState, CreateRoomUIState)
  and a duplicate ConversationCreationRepository import.
- Restore @serializable on ProvisioningCapability, lost in the merge.
- Fix ConversationCreationActivity's password-set dialog not dismissing
  after a successful save, and drop an unused ktlint-failing import and
  a misapplied @Suppress in ConversationCreationViewModel.

Assisted-by: Claude Code:claude-sonnet-5

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
rapterjet2004 force-pushed the bugfix/5923/validatePassword branch from e09386f to 3954359 Compare September 3, 2026 17:08
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33782782780/artifacts/9904545657
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi
@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

At least 1 approving review is required to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels

2. developing Work in progress AI assisted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Password policy app blocks room creation

3 participants

@sowjanyakch @mahibi @rapterjet2004