Skip to content

Pinned messages are now opened properly in threads - #5895

Merged
mahibi merged 1 commit into
masterfrom
issue-5860-pinned-thread-msg
Mar 4, 2026
Merged

Pinned messages are now opened properly in threads#5895
mahibi merged 1 commit into
masterfrom
issue-5860-pinned-thread-msg

Conversation

@rapterjet2004

@rapterjet2004 rapterjet2004 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

This uses the correct context to launch the message viewer. Also since thread messages are just regular messages with a thread id, If you pin a message in a thread, and try to access it outside the thread, it just opens it up in the chat context view.

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Feb 23, 2026
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Feb 23, 2026
@sowjanyakch

Copy link
Copy Markdown
Contributor

@rapterjet2004 - tested this PR and works as expected.

One small suggestion: when a pinned thread message is opened from the main conversation, the search results view points to the thread pinned message and from the UI it is hard to tell that it is a thread message (looks more like a reply to a message in this case). We could show a thread icon and title with the thread message, so it is obvious that the search result is a thread message. wdyt?

@rapterjet2004

Copy link
Copy Markdown
Contributor Author

One small suggestion: when a pinned thread message is opened from the main conversation, the search results view points to the thread pinned message and from the UI it is hard to tell that it is a thread message (looks more like a reply to a message in this case). We could show a thread icon and title with the thread message, so it is obvious that the search result is a thread message. wdyt?

Might be better off implemented in another PR, as I think deliberating over the thread feature's UI is outside the scope of issue #5895

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi
mahibi force-pushed the issue-5860-pinned-thread-msg branch from 5f5d4f9 to 7e22d1e Compare March 4, 2026 09:51
@mahibi
mahibi enabled auto-merge March 4, 2026 09:51
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5895.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@mahibi
mahibi merged commit cafa8f3 into master Mar 4, 2026
17 checks passed
@mahibi
mahibi deleted the issue-5860-pinned-thread-msg branch March 4, 2026 10:09
@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pinned message in thread behavior

4 participants