Show screenshares as fullscreen by mahibi · Pull Request #5402 · nextcloud/talk-android

mahibi · 2025-09-24T13:34:01Z

resolve no fullscreen-screensharing with muliple participants #1397

This PR will introduce to show screenshares as fullscreen

Whenever some shares the screen it will be shown as fullscreen
Screenshare can be closed by X button
Participants who share a screen have the screenshare icon which can be clicked
In screenshare view:
- zoom by pinching, move by dragging
- single tap to show the header with participant name and close button
- double tap to reset zoom level

This PR will also:

switch to software based rendering for screenshares so high resolution streams are supported for all devices.
- Other streams will continue to use hardware based rendering.
modify the call screen design, e.g.
- remove animated call controls so the screenshare buttons are not overlapped. Further improvements may come in the future.
migrate more code to Jetpack Compose
simplify classes around call architecture (e.g. by replacing classic observer patterns with kotlin flows)

Followup improvements should be:

for now, dragging of the self video view is removed. It will be re-implemented whenever the WebRtc lib is updated so we can make use of TextureViewRenderer.
- with TextureViewRenderer it should also be possible to have rounded corners for the self video view

🖼️ Video

ScreenshareFullscreenHandling.mp4

🚧 TODO

fix test testStateSentWithExponentialBackoffWhenAnotherParticipantAdded

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed
🔖 Capability is checked or not needed
🔙 Backport requests are created or not needed: /backport to stable-xx.x
📅 Milestone is set
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi · 2025-11-18T15:21:42Z

The test testStateSentWithExponentialBackoffWhenAnotherParticipantAdded fails for now:

org.mockito.exceptions.verification.TooManyActualInvocations: 
messageSender.send(
    NCSignalingMessage(from=null, to=null, type=unmute, payload=NCMessagePayload(type=null, sdp=null, nick=null, iceCandidate=null, name=audio, state=null, timestamp=null, reaction=null), roomType=video, sid=null, prefix=null),
    "theSessionId"
);
Wanted 4 times:
-> at com.nextcloud.talk.call.MessageSender.send(MessageSender.java:63)
But was 5 times:
-> at com.nextcloud.talk.call.LocalStateBroadcasterMcu.sendState(LocalStateBroadcasterMcu.java:115)
-> at com.nextcloud.talk.call.LocalStateBroadcasterMcu.sendState(LocalStateBroadcasterMcu.java:115)
-> at com.nextcloud.talk.call.LocalStateBroadcasterMcu.sendState(LocalStateBroadcasterMcu.java:115)
-> at com.nextcloud.talk.call.LocalStateBroadcasterMcu.sendState(LocalStateBroadcasterMcu.java:115)
-> at com.nextcloud.talk.call.LocalStateBroadcasterMcu.sendState(LocalStateBroadcasterMcu.java:115)


	at app//com.nextcloud.talk.call.MessageSender.send(MessageSender.java:63)
	at app//com.nextcloud.talk.call.LocalStateBroadcasterMcuTest.testStateSentWithExponentialBackoffWhenAnotherParticipantAdded(LocalStateBroadcasterMcuTest.kt:370)