Skip to content

Improve AccountDialogFragment - #5227

Merged
sowjanyakch merged 22 commits into
masterfrom
feature/5095/improveAccountDialogFragment
Oct 27, 2025
Merged

Improve AccountDialogFragment#5227
sowjanyakch merged 22 commits into
masterfrom
feature/5095/improveAccountDialogFragment

Conversation

@sowjanyakch

@sowjanyakch sowjanyakch commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix #5095.

  • Convert Rxjava into Coroutines.
  • MVVM architecture.
  • Jetpack compose

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from 2b4abf1 to b16b4e2 Compare August 5, 2025 16:39
@sowjanyakch
sowjanyakch marked this pull request as draft August 5, 2025 16:39
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch 2 times, most recently from 5891e08 to 8410fc9 Compare August 13, 2025 10:03
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch 2 times, most recently from 6e690c2 to 8c87187 Compare September 22, 2025 17:20
@sowjanyakch
sowjanyakch marked this pull request as ready for review September 22, 2025 17:32
@sowjanyakch sowjanyakch self-assigned this Sep 22, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Sep 22, 2025
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from 1bfc357 to 4d3ac42 Compare September 23, 2025 07:30
@sowjanyakch
sowjanyakch marked this pull request as draft September 23, 2025 09:26
@sowjanyakch
sowjanyakch marked this pull request as ready for review September 23, 2025 14:48
mahibi
mahibi requested changes Oct 1, 2025
View reviewed changes

@mahibi mahibi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The settings should be available when being offline. If some settings are not available offline, it should be handled inside the settings screen. But removing an account etc should be possible also without connection.

@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from efa3067 to f30b5b0 Compare October 6, 2025 15:49
@sowjanyakch

sowjanyakch commented Oct 6, 2025

Copy link
Copy Markdown
Contributor Author

settings option is shown in the accounts dialog when the device is offline. Handling settings screen will be done in a different PR. I created a seperate issue for it #5440

@sowjanyakch
sowjanyakch requested a review from mahibi October 6, 2025 15:56
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from f30b5b0 to 53cd86b Compare October 8, 2025 08:13
@mahibi

mahibi commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Can you squash into one commit?

@nickvergessen

nickvergessen commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Can you squash into one commit?

Let's save the time here if it's too complicated.
If we can deduplicate/merge commits with the same name or purpose, it of course makes sense.

@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch 3 times, most recently from ea10e02 to 8704cb4 Compare October 16, 2025 19:53
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from 8704cb4 to dddfc3c Compare October 22, 2025 15:26
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from dddfc3c to f409427 Compare October 23, 2025 17:19
@sowjanyakch
sowjanyakch enabled auto-merge October 23, 2025 17:20
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from f409427 to 0d33881 Compare October 27, 2025 08:31
@sowjanyakch
Rename .java to .kt
1d9cbbd 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
add composable dialog fragment
a32532c 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
add click listeners
2108de6 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
show red badge when actionsRequired
899be55 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
fix duplicate accounts
a829742 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
status should be display first
5b13c48 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
implementing MVVM and coroutines
44c307d 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
add repo in RepositoryModule
81cfd23 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
update ViewModelModule
84928e7 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
using composable with MVVM and coroutines
2f1117f 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
show accounts first and then apply badge if pending invitations are p…
6cff10f 
…resent

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
update header
b4d02dd 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
split status
d51b7c4 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
use tag
8369ec3 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
create data class - AccountItem
81cf2e6 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
add license header info
65e78d8 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
some more improvements to UI
8d3fe31 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
remove choose account xml file
0d6b127 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
some UI changes
0e27ac0 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
small layout changes
ddbe89d 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
show settings option when there is no internet connection
fd3a4aa 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
build fails due to unknown id (removed by xml).
5d6d0ee 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
sowjanyakch force-pushed the feature/5095/improveAccountDialogFragment branch from 0d33881 to 5d6d0ee Compare October 27, 2025 14:22
@github-actions

github-actions Bot commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5227.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions

github-actions Bot commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1110
Dodgy code6254
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9081

@sowjanyakch
sowjanyakch merged commit abf571d into master Oct 27, 2025
17 of 22 checks passed
@sowjanyakch
sowjanyakch deleted the feature/5095/improveAccountDialogFragment branch October 27, 2025 18:05
@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Oct 27, 2025
@mahibi mahibi mentioned this pull request Nov 21, 2025
Closed
@mahibi mahibi mentioned this pull request Dec 18, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes
@rapterjet2004 rapterjet2004 rapterjet2004 approved these changes

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

22.1.0

Development

Successfully merging this pull request may close these issues.

Improve ChooseAccountDialogFragment

5 participants

@sowjanyakch @mahibi @nickvergessen @rapterjet2004 @AndyScherzinger