Table scheme import by luka-nextcloud · Pull Request #2888 · nextcloud/tables

luka-nextcloud · 2026-08-12T12:34:07Z

🖼️ Screenshots

🏚️ Before	🏡 After
B	A

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed
🔙 Backport requests are created or not needed: /backport to stableX.X
📅 Milestone is set
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

The content of this PR was partly or fully generated using AI

blizzz

Early comments, some can be left for later.

UI wise it looks really nice already!

I would not display the UUID as title in the check box. It looks technical and table managers will have not deeper knowledge about it. Would completely keeps this identifier internal and instead use the New Title.
In my quick test I also see that Views would be dropped instead of being kept
Maybe need to double check the sort order as well when nothing is defined

This is very promising already! :)

blizzz · 2026-08-19T16:33:09Z

+	 */
+	#[NoAdminRequired]
+	#[RequirePermission(Application::PERMISSION_MANAGE, null, 'context', 'contextId')]
+	public function importScheme(int $contextId, ?string $name, ?string $iconName, ?string $description, ?array $nodes, ?array $tables): DataResponse {


Node sure I understand correctly the role of $nodes vs $tables. Maybe have an idea with the TODO against the nodes.

$nodes is array ids of tables and views to be shown. The $tables is array of related source tables.

blizzz · 2026-08-19T16:50:11Z

 		$columns = $this->columnService->findAllByTable($id, null, $table);
-		$this->enhanceTable($table, $userId);
-		return new TableScheme($table->getTitle(), $table->getEmoji(), $columns, $table->getViews() ?: [], $table->getDescription() ?: '', $this->appManager->getAppVersion('tables'), $table->getColumnOrderSettingsArray(), $table->getSortArray());
+		$this->enhanceTable($table, $userId ?? $this->userId);


i suppose there is a reason for this line change? ^

It would cause error when $userId is null

luka-nextcloud · 2026-08-20T09:46:31Z

@blizzz

In my quick test I also see that Views would be dropped instead of being kept

Does it mean that we should remove the Remove Views section?

Maybe need to double check the sort order as well when nothing is defined

Could you please share more details?

blizzz · 2026-08-20T14:13:12Z

@blizzz

In my quick test I also see that Views would be dropped instead of being kept

Does it mean that we should remove the Remove Views section?

No, that should be there!

In my test, the scheme file I uploaded did not have any changes with the views. However the dialog showed they would be removed, instead of kept.

luka-nextcloud · 2026-08-20T15:24:56Z

@blizzz

In my quick test I also see that Views would be dropped instead of being kept

Does it mean that we should remove the Remove Views section?

No, that should be there!

In my test, the scheme file I uploaded did not have any changes with the views. However the dialog showed they would be removed, instead of kept.

The application scheme includes the table schemes of related source tables. So it also detects the different views of those tables. Should we skip processing removed views when importing application scheme?

blizzz · 2026-08-20T21:33:03Z

schemes

@blizzz

In my quick test I also see that Views would be dropped instead of being kept

Does it mean that we should remove the Remove Views section?

No, that should be there!
In my test, the scheme file I uploaded did not have any changes with the views. However the dialog showed they would be removed, instead of kept.

The application scheme includes the table schemes of related source tables. So it also detects the different views of those tables. Should we skip processing removed views when importing application scheme?

Views that are missing in the scheme that is being imported shall be removed. In my case the detection was not correct, since they were still present, they should not be shown to be removed.

luka-nextcloud · 2026-08-21T07:45:13Z

@blizzz Do you mean that the view does present in the scheme but shown to be removed? It is strange, I cannot reproduce this issue. Could you please share the reproduce steps, as well as the scheme file you used and the uuid of the effected view?

Signed-off-by: Luka Trovic <luka@nextcloud.com>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Signed-off-by: Luka Trovic <luka@nextcloud.com>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz · 2026-08-21T19:44:44Z

+		if (!isset($tables['addTables']) || !is_array($tables['addTables'])
+			|| !isset($tables['modifyTables']) || !is_array($tables['modifyTables'])) {
+			throw new BadRequestError('Invalid tables structure provided.');
+		}


removing tables needs to be added as well, right?

We should not remove the tables since they might be used in another application. Updating $node already reflect the elements to show on that application.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

…bles into table-scheme-import

Signed-off-by: Luka Trovic <luka@nextcloud.com>

fixes updating columns when UUIDs are provided, e.g. during schema import. There we already have the proper local IDs in place. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Leads to confusion on other places, when it is re-imported and json_decoded. For example in schema update cases, it would result into identifying columns as modified while in fact they are unchanged. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz · 2026-08-24T21:59:38Z

I added two small commits with small fixes.

A bit unsure about f8e2e1c – here i soften the check and instead of erroring out, simply discard the submitted UUID. Easier on user front-ends. Also, when i would all passing this parameter, then the remaining call is set on true, but we have more entry points here afaik. cc @samin-z – FYI you had the error case and we talked about that as well.

More todos:

we need fix: ignore client sent option UUID and generate new UUID on column update #2899 extended with a migration step to add UUIDs to selection options where they are missing
- background: newly created selection options do not get the UUID set upon creation, hence they are not being treated correctly
after an import on the web interface, the data is not being updated/reloaded automatically (e.g. when a table title is being changed).

I still only tested a little bit, but spent maybe too long on those small changes (investigation time…).

enjeck

lots of comments...

enjeck · 2026-08-25T04:20:52Z

+		$nodes = $context->getNodes();
+		$tables = [];
+
+		foreach ($nodes as &$node) {


This leaves a dangling reference, so we should unset($node) after the loop?

It is unnecessary, we are not using the $node after loop.

Signed-off-by: Luka Trovic <luka@nextcloud.com>

blizzz · 2026-08-25T21:36:13Z

Views are shown as changed, because the columnUuid is not exposed in columnSettings in the export.
- I am also seeing that in columnSettings the columnUuid is not being exported, hence not present on import. It appears as a changed column. Views are being updated. At least cannot smuggle in a foreign column :)
It must be possible to import a table with an already present UUID. The idea is having portable tables that can be updated. The issue that we have here is that we require table UUIDs for Contexts, fortunately only for them! The limitation currently makes it impossible to have a copy of a table on the same instance (main use case is across instances, but not everybody may have that).
- My suggestion would be to catch the constrain in Table scheme import and regenerate the UUID. Or generate a new UUID for imported tables in general. But only for the Table! This should not cause any other issues when importing a scheme into a table (and we did not have it before – only added for Contexts.).
after importing a reload takes place, but it contains the old state
Contexts: Show in app list setting is not taken over (survivable)
✔️ Context shares are not taken over, but this actually makes sense, with importing across instances in mind.
i am not sure about the column order. I do not see we can change it in tables (but I recall there was a feature). The JSON exports fills the order, but importing shows the changes, but it does not have any effect.

Signed-off-by: Luka Trovic <luka@nextcloud.com>

- UUIDs on tables are not needed for their strucutre updates – …but for Contexts. When a table is used in them, it has to be shared Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Signed-off-by: Luka Trovic <luka@nextcloud.com>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz · 2026-08-26T15:40:40Z


 	test('Export scheme to json', async ({ userPage: { page } }) => {
 		const sourceScheme = await getTutorialScheme(page)
-		prepareSchemeForImport(sourceScheme, 'Imported scheme export')


tests succeed locally when i add this back

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

resolved

blizzz linked an issue Aug 14, 2026 that may be closed by this pull request

Structure update #2840

Closed

8 tasks

luka-nextcloud force-pushed the table-scheme-import branch from b73b4af to 2c9d442 Compare August 17, 2026 07:33

blizzz reviewed Aug 19, 2026

View reviewed changes

luka-nextcloud and others added 10 commits August 21, 2026 12:11

feat: add table scheme import endpoint

b70cf04

Signed-off-by: Luka Trovic <luka@nextcloud.com>

feat: add table scheme import UI

94a405f

Signed-off-by: Luka Trovic <luka@nextcloud.com>

feat: add context scheme export endpoint

0e23555

Signed-off-by: Luka Trovic <luka@nextcloud.com>

feat: add context scheme import endpoint

28190d9

Signed-off-by: Luka Trovic <luka@nextcloud.com>

feat: update table scheme import

8cdcb6b

Signed-off-by: Luka Trovic <luka@nextcloud.com>

enh: resolve schema changes

40fd230

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

feat: update table scheme change preview endpoint

eebf98b

Signed-off-by: Luka Trovic <luka@nextcloud.com>

feat: add uuid for table & context scheme change preview endpoint

09328d2

Signed-off-by: Luka Trovic <luka@nextcloud.com>

feat: add context scheme import function

8c6bdf1

Signed-off-by: Luka Trovic <luka@nextcloud.com>

fix: add minor improvements, remove redundant codes

5675453

Signed-off-by: Luka Trovic <luka@nextcloud.com>

blizzz reviewed Aug 21, 2026

View reviewed changes

Comment thread tests/unit/Service/StructureServiceTest.php

This comment was marked as resolved.

Sign in to view

fix(UUID): take over UUIDs for tables and views upon scheme import

c112d88

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz force-pushed the table-scheme-import branch from f57b358 to c112d88 Compare August 21, 2026 18:54

blizzz added 3 commits August 21, 2026 21:09

tests(Unit): add missing resource file

1e95762

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(Structure): wrong naming for filter

e27bb75

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

style(JS): apply stylint:fix

d82400f

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz force-pushed the table-scheme-import branch from be79f8e to d82400f Compare August 21, 2026 19:14

blizzz reviewed Aug 21, 2026

View reviewed changes

blizzz and others added 5 commits August 24, 2026 06:54

fix(OpenAPI): update parameter info and type definitions

790062b

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: wrongly provided parameters

5dfbf50

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix(OpenAPI): rebuild definitions

0f1fe5e

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge branch 'table-scheme-import' of https://github.com/nextcloud/ta…

6fbf738

…bles into table-scheme-import

fix: test issues

ac64ce5

Signed-off-by: Luka Trovic <luka@nextcloud.com>

luka-nextcloud marked this pull request as ready for review August 24, 2026 13:33

luka-nextcloud requested a review from enjeck as a code owner August 24, 2026 13:33

luka-nextcloud and others added 3 commits August 24, 2026 17:04

fix: lint issue

71591ff

Signed-off-by: Luka Trovic <luka@nextcloud.com>

enh: do not fail hard when an unwanted UUID is set, just remove it

f8e2e1c

fixes updating columns when UUIDs are provided, e.g. during schema import. There we already have the proper local IDs in place. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

enjeck reviewed Aug 25, 2026

View reviewed changes

enjeck previously requested changes Aug 25, 2026

View reviewed changes

fix: add table scheme validation & refactoring

7c9ddf7

Signed-off-by: Luka Trovic <luka@nextcloud.com>

blizzz reviewed Aug 26, 2026

View reviewed changes

Comment thread lib/Migration/Version2200Date20260819000000.php Outdated

luka-nextcloud and others added 5 commits August 26, 2026 14:29

fix: views changes & reloading tables issue

1009eb7

Signed-off-by: Luka Trovic <luka@nextcloud.com>

fix: avoid existing UUIDs against tables (across instance)

b5c9447

- UUIDs on tables are not needed for their strucutre updates – …but for Contexts. When a table is used in them, it has to be shared Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: take technical_name into account when importing

63c3532

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: reloading views issue

a43ee18

Signed-off-by: Luka Trovic <luka@nextcloud.com>

fix: avoid calling method with wrong parameter

43dbae7

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz reviewed Aug 26, 2026

View reviewed changes

test(playwright): avoid collisions

d46fe08

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz force-pushed the table-scheme-import branch from 7f5621d to d46fe08 Compare August 26, 2026 20:57

blizzz approved these changes Aug 26, 2026

View reviewed changes

blizzz merged commit c242fc4 into main Aug 26, 2026
79 checks passed

blizzz deleted the table-scheme-import branch August 26, 2026 21:11

blizzz mentioned this pull request Aug 26, 2026

enh: resolve schema changes #2841

Closed

1 task

enjeck mentioned this pull request Aug 30, 2026

🗃️ Structure import #2504

Closed

5 tasks

Uh oh!

Conversation

luka-nextcloud commented Aug 12, 2026

🖼️ Screenshots

🏁 Checklist

🤖 AI (if applicable)

Uh oh!

blizzz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luka-nextcloud commented Aug 20, 2026

Uh oh!

blizzz commented Aug 20, 2026

Uh oh!

luka-nextcloud commented Aug 20, 2026

Uh oh!

blizzz commented Aug 20, 2026

Uh oh!

luka-nextcloud commented Aug 21, 2026

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blizzz commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enjeck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

blizzz commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blizzz left a comment •

edited

Loading

blizzz commented Aug 24, 2026 •

edited

Loading

blizzz commented Aug 25, 2026 •

edited

Loading