[stable1.0] fix: add validation for columnDto - #2715
Merged
Conversation
enjeck
force-pushed
the
backport/2414/stable1.0
branch
2 times, most recently
from
June 16, 2026 06:23
81dbfd3 to
992e612
Compare
enjeck
requested changes
Jun 16, 2026
Comment on lines
+19
to
+20
| if ($textMaxLength !== null && $textMaxLength < 0) { | ||
| throw new BadRequestError('Maximum text length must be greater than or equal to 0.'); |
Contributor
There was a problem hiding this comment.
-1 is the sentinel value for "no maximum length" (e.g. existing/imported schemes), so only values below -1 are invalid.
Suggested change
| if ($textMaxLength !== null && $textMaxLength < 0) { | |
| throw new BadRequestError('Maximum text length must be greater than or equal to 0.'); | |
| if ($textMaxLength !== null && $textMaxLength < -1) { | |
| throw new BadRequestError('Maximum text length must be greater than or equal to 0.'); |
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
enjeck
force-pushed
the
backport/2414/stable1.0
branch
from
August 29, 2026 07:06
992e612 to
78a93cb
Compare
enjeck
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2414