Fix respect view column order in public sharing#2701
Open
taiebot wants to merge 3 commits into
Open
Conversation
AndyScherzinger
added
enhancement
enjeck
requested changes
Jun 15, 2026
enjeck
left a comment
enjeck
left a comment
Contributor
There was a problem hiding this comment.
Look good, except for the linting errors. Can be fixed by running npm run lint:fix
Contributor
|
Also, need to sign commits to fix DCO: https://github.com/nextcloud/tables/pull/2701/checks?check_run_id=81362784234 |
Signed-off-by: taiebot <dedreuil@yahoo.fr>
Contributor
|
hmm, seems like we still need to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment filtered views are not sorted as per the view column order if you share them pubicly
with this PR they are sorted and respect the table order. this will fix #2595
Screenshot of private view
in public sorted
with an other order.
