Skip to content

Fix: Make case-insensitive search for the usergroup and multi selection columns - #2446

Merged
enjeck merged 1 commit into
mainfrom
bugfix/make-usergroup-selection-milti-filters-case-insensetiv
Aug 29, 2026
Merged

Fix: Make case-insensitive search for the usergroup and multi selection columns#2446
enjeck merged 1 commit into
mainfrom
bugfix/make-usergroup-selection-milti-filters-case-insensetiv

Conversation

@Koc

@Koc Koc commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

This is a follow-up for the #1798. It spreads same logic what we have in text line type to other column types. So, now everything is case insensitive.

It also fixes filters for usergroup single selection

🔘 Single selection

Before After
image image

☑️ Multi selection

Before After
image image

👤 User single selection

Before After
image image

👥 User multi selection

Before After
image image

@Koc
Koc requested review from blizzz and enjeck as code owners April 5, 2026 22:14
@Koc
Koc force-pushed the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch from a3b8def to 120718e Compare April 5, 2026 22:40

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some comments:

Comment thread src/shared/components/ncTable/mixins/columnsTypes/usergroup.js Outdated
Comment thread src/shared/components/ncTable/mixins/columnsTypes/selectionMulti.js Outdated
@Koc
Koc force-pushed the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch from 120718e to fe95c8c Compare April 26, 2026 17:49
@Koc
Koc force-pushed the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch 4 times, most recently from c1e07dc to b342f82 Compare June 25, 2026 23:22
Comment thread src/shared/components/ncTable/mixins/columnsTypes/selection.js
Comment thread src/shared/components/ncTable/mixins/columnsTypes/selection.js Outdated
@Koc
Koc force-pushed the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch 2 times, most recently from b2edadc to 28efb9a Compare June 30, 2026 16:10
@Koc
Koc requested a review from enjeck July 6, 2026 13:44
@Koc
Koc force-pushed the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch from 28efb9a to 33f54ed Compare July 23, 2026 20:56
@Koc
Koc force-pushed the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch from 33f54ed to 986e395 Compare August 27, 2026 10:01
Comment thread src/shared/components/ncTable/mixins/columnsTypes/textLink.js Outdated
Comment thread src/shared/components/ncTable/mixins/columnsTypes/textLong.js Outdated
…on columns

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Koc force-pushed the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch from 986e395 to c2ada81 Compare August 27, 2026 22:13

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much! 🚀

@enjeck
enjeck merged commit 74fc165 into main Aug 29, 2026
60 checks passed
@enjeck
enjeck deleted the bugfix/make-usergroup-selection-milti-filters-case-insensetiv branch August 29, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants