Skip to content

feat: add relation column type#2248

Merged
enjeck merged 3 commits into
mainfrom
feature/add-relations-column-type
Jun 16, 2026
Merged

feat: add relation column type#2248
enjeck merged 3 commits into
mainfrom
feature/add-relations-column-type

Conversation

@Koc

@Koc Koc commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

This PR introduces a basic relation type. It allows to connect few tables together. We will store row id as a column value and display selected column as a label for this values. Closes #172.

✔️ Implemented

🔍 Column create/edit

image

🔍 Row create/edit via popup/inline

image

🔍 Row display in table/view + handle relation row removal

image image

🔍 Filter for view

image

🔍 Filter for rows

image image

🔍 Import/Export

image image

🚧 Pending (help welcomed):

  • Behat tests
  • Cypress tests?

❎ What is out of scope:

  • Lookup columns to add an extra columns from the related table to the current one. It will be handled separately in upcoming PR.

@Koc Koc force-pushed the feature/add-relations-column-type branch from c3f6a2d to fdd744e Compare January 15, 2026 17:44
@Koc Koc force-pushed the bugfix/fix-loading-of-large-tables branch from f792683 to f599f40 Compare January 15, 2026 19:21
@Koc Koc force-pushed the feature/add-relations-column-type branch 6 times, most recently from 92af03c to 0f9416b Compare January 16, 2026 00:28
@Aveyron-RetD Aveyron-RetD mentioned this pull request Jan 16, 2026
@Koc Koc force-pushed the feature/add-relations-column-type branch 3 times, most recently from 6a4e073 to 5209182 Compare January 16, 2026 18:06
@Koc Koc changed the base branch from bugfix/fix-loading-of-large-tables to main January 16, 2026 18:06
@Koc Koc force-pushed the feature/add-relations-column-type branch 4 times, most recently from fb98364 to 198afa1 Compare January 16, 2026 18:43
@Koc Koc marked this pull request as ready for review January 16, 2026 19:12
@Koc Koc requested review from blizzz and enjeck as code owners January 16, 2026 19:12
@Koc Koc force-pushed the feature/add-relations-column-type branch from 198afa1 to ddc1bd1 Compare January 16, 2026 20:45
@juliusknorr juliusknorr added the enhancement New feature or request label Jan 21, 2026
@juliusknorr juliusknorr requested a review from samin-z January 21, 2026 20:49
@Koc Koc force-pushed the feature/add-relations-column-type branch 2 times, most recently from f34f8f9 to d406233 Compare January 25, 2026 12:47
@Koc Koc force-pushed the feature/add-relations-column-type branch 4 times, most recently from f092bad to 502b69b Compare February 12, 2026 23:24
@Aveyron-RetD

Aveyron-RetD commented Mar 30, 2026

Copy link
Copy Markdown

So I have user tested and this looks good. 👍 Could not get it to work at first because I did not get that only text field were working. This will create maybe some confusion on first use. Not all tables do have this text field. Perhaps a comment with a small tooltip with a little (i) in the screenshot below to explain that you can only link that kind of data
image

For my mention of #2035 this is not a good fit.
I was hoping that this would solve the one-to-many expansion I have been dreaming about, but no :-( .

@Koc

Koc commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

I was hoping that this would solve the one-to-many expansion I have been dreaming about, but no :-( .

@Aveyron-RetD yeah, I'm aware about that case. But you need to understand me as well: feature is really huge, we should start from something simple and improve it in upcoming iterations 🤝

I will add tooltip soon. Hope that we can merge it soon 🙏

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Apr 12, 2026
@enjeck enjeck force-pushed the feature/add-relations-column-type branch from 3240639 to 0cdfefa Compare April 23, 2026 03:47
Comment thread src/shared/components/ncTable/mixins/filter.js Outdated

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have tests to avoid regressions in the future

@Koc Koc force-pushed the feature/add-relations-column-type branch 3 times, most recently from b707106 to f3c29d8 Compare May 4, 2026 21:45
@Koc

Koc commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

@Aveyron-RetD here we go, without tooltip

image

@Koc Koc force-pushed the feature/add-relations-column-type branch 2 times, most recently from b426237 to 5752ee3 Compare May 7, 2026 14:09
Comment thread tests/integration/features/APIv2.feature Outdated
@Koc Koc force-pushed the feature/add-relations-column-type branch 5 times, most recently from 5287072 to 5ab7cee Compare June 6, 2026 23:55
@Koc

Koc commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

hey @enjeck @blizzz!

I've added Behat tests, please check. Is that enough to merge PR?

@enjeck enjeck force-pushed the feature/add-relations-column-type branch 2 times, most recently from 43f8c6c to 5b58b04 Compare June 16, 2026 05:20
Koc and others added 3 commits June 16, 2026 07:25
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck enjeck force-pushed the feature/add-relations-column-type branch from c83c383 to 1bd767b Compare June 16, 2026 06:25

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@enjeck enjeck merged commit 7b1b385 into main Jun 16, 2026
75 checks passed
@enjeck enjeck deleted the feature/add-relations-column-type branch June 16, 2026 06:57
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 📝 Productivity team Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Relational properties

6 participants