Skip to content

feat: lazy initialization for editor setup - #2212

Merged
enjeck merged 2 commits into
mainfrom
fix/2174
Jan 12, 2026
Merged

feat: lazy initialization for editor setup#2212
enjeck merged 2 commits into
mainfrom
fix/2174

Conversation

@enjeck

@enjeck enjeck commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

fixes #2174

When there are many rich text cells, the page lags and while each editor is being loaded. This improves performance by only loading the cell when it's scrolled into the user's view

@enjeck
enjeck requested a review from juliusknorr December 9, 2025 07:07
@enjeck enjeck self-assigned this Dec 9, 2025
@enjeck
enjeck requested a review from blizzz as a code owner December 9, 2025 07:07
Comment thread lib/Controller/PageController.php
Comment thread src/shared/components/ncEditor/NcEditor.vue Outdated

@juliusknorr juliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, but i think we can simplify it and drop the fallback case

@juliusknorr

Copy link
Copy Markdown
Member

Ci also needs some work to pass ;)

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
enjeck merged commit 1c32529 into main Jan 12, 2026
65 of 67 checks passed
@enjeck
enjeck deleted the fix/2174 branch January 12, 2026 04:23
@enjeck

enjeck commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable1.0

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jan 12, 2026
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline rich text rendering has performance issues

2 participants