Enhancement: Reduce logs for non-existent circles - #2209
Merged
Conversation
Member
|
I would argue the caching layer is better applied somewhere at the source, speak circles app,, https://github.com/nextcloud/circles/blob/master/lib/Service/CircleService.php or https://github.com/nextcloud/circles/blob/master/lib/Db/CircleRequest.php |
Koc
force-pushed
the
feature/reduce-logs-for-non-existent-circles
branch
from
December 8, 2025 17:06
e7b67f9 to
12bf7b7
Compare
Koc
changed the title
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/reduce-logs-for-non-existent-circles
branch
from
December 8, 2025 17:07
12bf7b7 to
8baa44b
Compare
Contributor
Author
|
@blizzz cache layer reverted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have really large tables and dynamic circles that can be removed. For now we suffer from logs like
Failed to get circle display name. This PR aims to get rid of this log for non existing circles (but keep log for other errors).