refactor: remove unnecessary parameter (plus cleanup) - #2186
Merged
Conversation
… and with this a DB query that would run often enough. More cleanups include: - remove call-by-ref indicators where objects were passed - removed unused variables - remove wrong and unneeded PHP doc - a few simplifictations (if, available PHP methods) - fix some minor code smells - add missing return type hint Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
bug
Member
Author
|
/backport to stable0.9 |
benjaminfrueh
approved these changes
Dec 5, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted that
parseEntities()is accepting acolumnTypesparameter, which it actually does not use. The callee however runs a DB query for that. Since it is ingetRowsand often called, a good thing to shave off. Though probably not much of effect, hence not daring to call it a performance improvement 😅 Added more cleanup in the course.