Skip to content

fix: improve number input validation and update handling - #2182

Merged
enjeck merged 2 commits into
mainfrom
fix/2154
Aug 29, 2026
Merged

fix: improve number input validation and update handling#2182
enjeck merged 2 commits into
mainfrom
fix/2154

Conversation

@enjeck

@enjeck enjeck commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

fixes #2154

@enjeck
enjeck requested a review from silverkszlo December 3, 2025 07:12
@enjeck enjeck self-assigned this Dec 3, 2025
@enjeck
enjeck requested a review from blizzz as a code owner December 3, 2025 07:12
@enjeck enjeck added the 3. to review Waiting for reviews label Dec 3, 2025
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Dec 3, 2025
@enjeck
enjeck force-pushed the fix/2154 branch 3 times, most recently from 3d19f28 to 332bf03 Compare December 3, 2025 08:27
@blizzz

blizzz commented Dec 4, 2025

Copy link
Copy Markdown
Member

Maybe it is not a regression, but still strikes me awkward: the lower number is inclusive, but the upper limit number is exclusive?

Anyway, what I am not sure about is that numbers are changed to either lower or highest value, depending where they are created. I wonder whether this is OK, or whether there should be an error instead. UX question.

Screencast_20251204_110805.webm

@enjeck
enjeck force-pushed the fix/2154 branch 2 times, most recently from 99901c7 to 4359820 Compare June 28, 2026 06:33
@enjeck

enjeck commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Okay, should be fixed now:

  • the check uses value < min and value > max, both inclusive, matching native HTML5 min/max.
  • there's no silent overwrite anymore.

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@blizzz

blizzz commented Jul 2, 2026

Copy link
Copy Markdown
Member

Locally, i have number tests failing, might need adjustement?

image

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
enjeck merged commit 2ebda9b into main Aug 29, 2026
60 checks passed
@enjeck
enjeck deleted the fix/2154 branch August 29, 2026 06:51
@github-project-automation github-project-automation Bot moved this from 馃Л Planning evaluation (don't pick) to 鈽戯笍 Done in 馃摑 Productivity team Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Status: 鈽戯笍 Done

Development

Successfully merging this pull request may close these issues.

Input behaviour broken for numbers with defined min/max values

2 participants