fix: Add key to pre-existing usergroup items - #2117
Merged
Merged
Conversation
benjaminfrueh
approved these changes
Oct 28, 2025
enjeck
force-pushed
the
add-key-to-usergroup
branch
from
November 7, 2025 10:06
0a631ca to
78023c9
Compare
blizzz
approved these changes
Nov 11, 2025
enjeck
force-pushed
the
add-key-to-usergroup
branch
2 times, most recently
from
November 11, 2025 19:26
76b5338 to
eaf08e2
Compare
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
enjeck
force-pushed
the
add-key-to-usergroup
branch
from
November 11, 2025 19:26
eaf08e2 to
05b087f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce the problem:
This happens because there's no key associated with the item. So, we therefore add keys to the pre-existing usergroup items. With keys, only the clicked item is cleared.