Skip to content

build(deps): claim supporting NC 33 - #2097

Merged
blizzz merged 3 commits into
mainfrom
build/claim-33-support
Oct 8, 2025
Merged

build(deps): claim supporting NC 33#2097
blizzz merged 3 commits into
mainfrom
build/claim-33-support

Conversation

@blizzz

@blizzz blizzz commented Oct 7, 2025

Copy link
Copy Markdown
Member

Eases development and tests against server master 馃槄

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzz requested a review from enjeck as a code owner October 7, 2025 18:27
@blizzz blizzz added enhancement New feature or request 3. to review Waiting for reviews labels Oct 7, 2025

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzz force-pushed the build/claim-33-support branch from 6cc8947 to 6e887ce Compare October 7, 2025 19:49
@blizzz

blizzz commented Oct 7, 2025

Copy link
Copy Markdown
Member Author
image

The performance tests fails now because the old value in tests/integration/base-query-count.txt is from May 2023 and the tests was skipped before. For the condition was: if: ${{ matrix.databases == 'mysql' && matrix.php-versions == '8.2' && matrix.server-versions == 'master' && github.event_name == 'pull_request' }}

master did not run against 8.2 for a long run 馃檭 and there's been a ton of tests added

Execution if the tests were skipped for a long time as the condition
included to run on server master and PHP 8.2 which did not happen for a
long time. Keeping the value at the lowest master version so we notice
when to bump. Also a lot of tests were added since, so updating the base
number as the old one has no meaning anymore.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzz merged commit 6083055 into main Oct 8, 2025
73 of 79 checks passed
@blizzz
blizzz deleted the build/claim-33-support branch October 8, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants