1769 views set mandatory state of a column

[silverkszlo]

Resolves #1769

Add the possibility to make columns in views mandatory.

TODO:

• add tests
• fix validation for mandatory datetime fields

[enjeck]

@blizz Would appreciate a review!

[enjeck]

Doing all this to ensure that when row requests are made via the API, the mandatory condition is respected. Maybe there's an easier way to do it?

[blizzz]

in ResponseDefinitions.php, the API documentation need to be extended by the mandatory key, similar as in https://github.com/nextcloud/tables/pull/1958/files#diff-b15c74adf6c164ed61707f0a48432bb4df4972b0f3994256778091bcd83172e8R29

[silverkszlo]

@enjeck and @blizzz I would appreciate another review of the latest commits beginning with that one: e309b7e

[blizzz]

Would appreciate a review!

The one with two z is some other person btw 😁 (classic)

[blizzz]

Works like a charm!

I suppose the cypress errors are unrelated…?

[silverkszlo]

Works like a charm!

I suppose the cypress errors are unrelated…?

The failing test in view-filtering-selection.cy.js was related to this PR, because I have fixed a typo in ViewSettings.vue (changed this.viewSettings to this.viewSetting in saveText()). Because of the typo the else if-clause would never come true and the button would never say "Save modified View". It always said "Save View" instead, which the test was expecting. Fixing the typo meant that the button would display "Save modified View" eventually, so I have adjusted to test and now it passes.

The failing test in view.cy.js on ther other hand is unrelated to this PR because it also fails in #1718 . As I have just noticed that now and thought that the failing test was indeed related to this PR, I have worked on a fix here. It seems that it did the trick. Had to restructure the test and follow the pattern of other passing tests.

• The test was failing because it couldn't find the customTableAction button. The original test tried to access customTableAction in the beforeEach hook before properly loading the table context.
• I also adjusted the Cleanup Strategy: Changed from afterEach() to after() to prevent table deletion between tests.
  This prevents row accumulation issues across tests.

The key insight was that customTableAction only renders properly when the table is loaded in the correct context via cy.loadTable(), not when accessed immediately after table creation.

[enjeck]

I was just testing again and I realized that the mandatory field doesn't work for the SelectionCheckForm type. Both checked and unchecked cases give an error saying that the field is empty.

The UsergroupForm doesn't work either, allowing me to save even when empty and mandatory. THis is also a problem not just for the views, but for the mandatory field that can be set on the table's column (unrelated to this PR, but could be nice to fix here while fixing the view case)

[enjeck]

Here's the problem I was talking about:

Screen.Recording.2025-09-25.at.04.29.15.mov

I introduced the bug anyway, lol. So went ahead and fixed at 2f19064

[enjeck]

nice!